cli: remove old migration steps and id-file references #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-weisse
requested review from
elchead,
derpsteb and
malt3
as code owners
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
malt3
approved these changes
Oct 11, 2023
|
linked the AB ticket |
elchead
approved these changes
Oct 11, 2023
derpsteb
reviewed
Oct 11, 2023
| @@ -513,34 +463,6 @@ func (u *upgradeApplyCmd) handleServiceUpgrade( | |||
| return nil | |||
| } | |||
|
|
|||
| // migrateFrom2_10 applies migrations necessary for upgrading from v2.10 to v2.11 | |||
| // TODO(v2.11): Remove this function after v2.11 is released. | |||
| func migrateFrom2_10(ctx context.Context, kubeUpgrader kubernetesUpgrader) error { | |||
There was a problem hiding this comment.
We decided at some point to make such functions nops, to act as guide for future migration additions. But I am also fine with removing them.
derpsteb
approved these changes
Oct 11, 2023
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
ref/cli/id-file-removal
branch
from
3b3da15 to
33fca51
Compare
Coverage report
|
|
GCP upgrade ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ID file is not used anymore, and some helm/kubernetes migrations are no longer necessary.
Proposed change(s)
Related issue