cli: revert libvirt terraform provider upgrade #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
approved these changes
Oct 16, 2023
miniConstellation e2e test have been failing since this was merged
Yes, but I don't think running the e2e tests specifically for the one PR is necessary, since our daily/weekly tests catch this issue. I would also not expect every dependency update to bring in issues that inhibit usage of said dependency (which is the case here). |
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
revert/libvirt-v0.7.1
branch
from
f356a9a to
9d3feb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#2434 upgraded the libvirt terraform provider to v7.4.
That version seems to have broken support for connection URIs, making Terraform seem to completely ignore the paramter.
This means that even if the libivrt URI is set to something like
qemu+tcp://localhost:16599/system, it will default to the system host libvirt.We need to revert that commit for our Docker-libvirt setup to still be functional.
Proposed change(s)
Additional info