Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add e2e test for self-managed infrastructure #2472

Merged
merged 29 commits into from
Oct 27, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 17, 2023

Context

There should be an e2e-test of the self-managed infrastructure workflow we also describe in our docs. This is related to #2458.

Proposed change(s)

  • Add a test payload self-managed infra to test self-managed infrastructure creation as a substitution to constellation create

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Oct 17, 2023
@msanft msanft requested review from 3u13r and daniel-weisse October 17, 2023 10:15
@msanft msanft added this to the v2.13.0 milestone Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit a660d43
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/653b5e0579e0e5000858d824

@msanft msanft force-pushed the feat/ci/self-managed-infra-e2e branch from c9650d5 to d37692d Compare October 19, 2023 07:07
@msanft msanft marked this pull request as ready for review October 19, 2023 07:34
hack/image-fetch/main.go Outdated Show resolved Hide resolved
@msanft msanft force-pushed the feat/ci/self-managed-infra-e2e branch 2 times, most recently from 6ae2a2e to 151fddf Compare October 20, 2023 17:13
@msanft msanft requested a review from 3u13r October 23, 2023 06:57
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msanft msanft force-pushed the feat/ci/self-managed-infra-e2e branch 4 times, most recently from 2c13c37 to aecf893 Compare October 26, 2023 06:48
Comment on lines 263 to 270
selfManagedInfra: "true"

- name: Always terminate cluster
if: always()
uses: ./.github/actions/constellation_destroy
with:
kubeconfig: ${{ steps.e2e_test.outputs.kubeconfig }}
selfManagedInfra: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reverted/moved to its own workflow before merging

@msanft
Copy link
Contributor Author

msanft commented Oct 26, 2023

We need to patch the MAA manually before init on Azure, which we currently only do in the CLI.

Oct 26 15:04:52 fedora bootstrapper[8984]: {"level":"WARN","ts":"2023-10-26T15:0
4:52Z","logger":"bootstrapper","caller":"vtpm/attestation.go:109","msg":"Failed 
to issue attestation statement: fetching instance info: creating MAA token: gett
ing encrypted token: MAA returned 400 Bad Request: {\"error\":{\"code\":\"Policy
EvaluationError\",\"message\":\"Policy Evaluation Error has occurred\",\"innerer
ror\":{\"code\":\"PolicyValidationFailure\",\"details\":[{\"code\":\"PolicyFailu
reLine\",\"target\":\"Line\",\"value\":\"[type==\\\"secureboot\\\", value==false
] => deny();\"},{\"code\":\"PolicyFailureClaim\",\"target\":\"secureboot\",\"val
ue\":\"false\"}],\"message\":\"A Deny claim was issued, authorization failed.\"}
}}"}

@msanft msanft force-pushed the feat/ci/self-managed-infra-e2e branch from 492773d to 1bea9dd Compare October 26, 2023 17:10
@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cloudcmd 65.10% 67.90% ↗️
cli/internal/cmd 53.40% 53.40% ↔️
hack/image-fetch 0.00% 0.00% 🆕
hack/maa-patch 0.00% 0.00% 🆕
internal/maa 0.00% 26.90% 🆕

@msanft msanft merged commit 402a883 into main Oct 27, 2023
7 checks passed
@msanft msanft deleted the feat/ci/self-managed-infra-e2e branch October 27, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants