Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image: use systemd-dissect from the host when calculating measurements #2473

Merged
merged 2 commits into from
Oct 17, 2023
Merged

image: use systemd-dissect from the host when calculating measurements #2473

merged 2 commits into from
Oct 17, 2023

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Oct 17, 2023 •
edited
Loading

Context

A proper solution would be parsing the EFI partition directly in Go and not shelling out to systemd-dissect with root privileges. This needs more time.

When using systemd-dissect from nixpkgs, we see the following error:

  (10:03:53) INFO: Running command line: /bin/bash -c 'sudo -E bazel-bin/image/measured-boot/cmd/cmd_/cmd /home/runner/work/constellation/constellation/constellation.raw /home/runner/work/constellation/constellation/pcrs-aws-aws-nitro-tpm.json'
  failed to extract UKI: failed to extract /efi/EFI/BOOT/BOOTX64.EFI from /home/runner/work/constellation/constellation/constellation.raw: exit status 1
  Failed to open source path '/efi/EFI/BOOT/BOOTX64.EFI' in image '/home/runner/work/constellation/constellation/constellation.raw': No such file or directory

Proposed change(s)

  • image: use systemd-dissect from the host when calculating measurements

Checklist

@malt3 malt3 added the no changelog Change won't be listed in release changelog label Oct 17, 2023
@malt3 malt3 added this to the v2.13.0 milestone Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 58419f4
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/652e648066ed2d00080804fd

@malt3 malt3 requested a review from daniel-weisse October 17, 2023 10:29
@malt3 malt3 merged commit e93de82 into main Oct 17, 2023
30 checks passed
@malt3 malt3 deleted the fix/image/dissect-from-host branch October 17, 2023 11:26
elchead pushed a commit that referenced this pull request Oct 17, 2023
@malt3 @elchead
image: use systemd-dissect from the host when calculating measurements (
0ee1df9 
#2473)

* image: use systemd-dissect from the host when calculating measurements

* ci: setup bazel and nix toolchains before merging os image measurements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@malt3 @daniel-weisse