Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix joining over lb #2478

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix joining over lb #2478

merged 1 commit into from
Oct 19, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Oct 19, 2023

Context

This is a fix needed for the strict node-to-node encryption. This bug had no effect until recently since we can still join via directly requesting the node in the local VPC.

Proposed change(s)

  • Don't append the port to the lb join endpoint twice.

Additional info

  • Any additional information or context

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added the no changelog Change won't be listed in release changelog label Oct 19, 2023
@3u13r 3u13r added this to the v2.13.0 milestone Oct 19, 2023
@3u13r 3u13r requested a review from malt3 October 19, 2023 13:13
@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit c4b2c54
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65312b78b526ce0008627372

@3u13r 3u13r requested a review from daniel-weisse October 19, 2023 13:13
@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
bootstrapper/internal/joinclient 88.50% 88.50% ↔️

@3u13r 3u13r merged commit 6c0a3b8 into main Oct 19, 2023
7 checks passed
@3u13r 3u13r deleted the fix/bootstrapper/join-endpoint branch October 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants