Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add constellation apply command to replace init and upgrade apply #2484

Merged
merged 8 commits into from
Oct 26, 2023
Merged

cli: add constellation apply command to replace init and upgrade apply #2484

merged 8 commits into from
Oct 26, 2023

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Oct 20, 2023 •
edited
Loading

Context

#2449 replaces the backend code for init and upgrade apply with one common implementation.
This PR adds a new command to replace both init and upgrade apply with a single command.

Proposed change(s)

  • Add constellation apply command
  • Mark constellation init and constellation upgrade apply as deprecated
  • Use constellation apply in CI

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@daniel-weisse daniel-weisse added the feature This introduces new functionality label Oct 20, 2023
@daniel-weisse daniel-weisse added this to the v2.13.0 milestone Oct 20, 2023
@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch from 21f1d7c to 6c464dc Compare October 20, 2023 08:53
3u13r
3u13r requested changes Oct 20, 2023
View reviewed changes
cli/internal/cmd/apply.go Outdated Show resolved Hide resolved
@elchead
Copy link
Contributor

elchead commented Oct 20, 2023 •
edited
Loading

should we also apply the apply pattern to iam to be consistent again?(as follow up)

@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-backend branch from 7f42631 to c522607 Compare October 23, 2023 08:41
@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch 2 times, most recently from 1430290 to 2c5feaf Compare October 24, 2023 08:31
thomasten
thomasten reviewed Oct 24, 2023
View reviewed changes
cli/cmd/root.go Outdated Show resolved Hide resolved
cli/internal/cmd/apply.go Outdated Show resolved Hide resolved
cli/internal/cmd/apply.go Outdated Show resolved Hide resolved
@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-backend branch from c522607 to b082669 Compare October 24, 2023 13:26
Base automatically changed from feat/cli/apply-backend to main October 24, 2023 13:39
@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch from 2c5feaf to cb27cf7 Compare October 24, 2023 13:41
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 8bf9b11
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/653a0b2e8dc0c100083270f9

@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch from c12065b to f56fb86 Compare October 24, 2023 14:12
@daniel-weisse daniel-weisse force-pushed the feat/cli/apply-command branch from f56fb86 to 8bf9b11 Compare October 26, 2023 06:46
@daniel-weisse daniel-weisse requested a review from 3u13r October 26, 2023 06:46
@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/cmd [no test files] [no test files] 🚧
cli/internal/cmd 52.80% 53.10% ↗️
e2e/internal/upgrade [no test files] [no test files] 🚧

@3u13r 3u13r removed their request for review October 26, 2023 13:55
3u13r
3u13r approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-weisse daniel-weisse merged commit 149fedb into main Oct 26, 2023
9 checks passed
@daniel-weisse daniel-weisse deleted the feat/cli/apply-command branch October 26, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasten thomasten thomasten approved these changes

@elchead elchead elchead approved these changes

@3u13r 3u13r 3u13r approved these changes

@derpsteb derpsteb derpsteb approved these changes

Assignees
No one assigned
Labels
feature This introduces new functionality
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@daniel-weisse @elchead @derpsteb @3u13r @thomasten