Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugd: add missing self-managed-infra field #2542

Merged
merged 1 commit into from
Oct 31, 2023
Merged

debugd: add missing self-managed-infra field #2542

merged 1 commit into from
Oct 31, 2023

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Oct 31, 2023

Context

The fields need to be allowed explicitly in the debugd, otherwise causing a failure.

Proposed change(s)

  • Add the missing field.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Oct 31, 2023
@msanft msanft added this to the v2.13.0 milestone Oct 31, 2023
@msanft msanft requested a review from daniel-weisse October 31, 2023 07:20
@msanft msanft requested a review from malt3 as a code owner October 31, 2023 07:20
@netlify
Copy link

netlify bot commented Oct 31, 2023

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 625b5c0
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6540aaae202217000851ff4d

@github-actions
Copy link
Contributor

Coverage report

Package Old New Trend
debugd/internal/debugd/logcollector 12.70% 12.70% 🚧

@daniel-weisse
Copy link
Member

You can close the failure tickets when this is merged

@msanft msanft merged commit 0c03076 into main Oct 31, 2023
@msanft msanft deleted the fix/debugd/add-missing-field branch October 31, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@malt3 malt3 Awaiting requested review from malt3

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msanft @daniel-weisse