Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: notify with GH issue + project item on e2e failure #2607

Merged
merged 5 commits into from
Nov 22, 2023
Merged

ci: notify with GH issue + project item on e2e failure #2607

merged 5 commits into from
Nov 22, 2023

Conversation

elchead
Copy link
Contributor

@elchead elchead commented Nov 16, 2023 •
edited
Loading

Context

Proposed change(s)

  • remove Teams notification
  • add GH project item + issue on E2E failure

Additional info

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@elchead elchead force-pushed the feat/ci/gh-issue-on-failure branch from 642c067 to 760b4a7 Compare November 16, 2023 12:52
@elchead elchead requested a review from katexochen November 16, 2023 12:56
katexochen
katexochen previously requested changes Nov 16, 2023
View reviewed changes
.github/actions/notify_e2e_failure/action.yml Outdated Show resolved Hide resolved
@elchead elchead marked this pull request as ready for review November 16, 2023 14:46
@elchead elchead requested a review from katexochen November 16, 2023 14:46
@elchead elchead added the no changelog Change won't be listed in release changelog label Nov 16, 2023
@elchead elchead added this to the v2.14.0 milestone Nov 16, 2023
@elchead elchead changed the base branch from feat/ci/ghissue to main November 16, 2023 15:04
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 53348d9
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/655df6560f329e0008f0ba34
😎 Deploy Preview https://deploy-preview-2607--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elchead elchead force-pushed the feat/ci/gh-issue-on-failure branch 2 times, most recently from 9def3f8 to 8980785 Compare November 20, 2023 09:23
@katexochen
Copy link
Member

@elchead can you clean up the commit history?

@elchead elchead force-pushed the feat/ci/gh-issue-on-failure branch from 8980785 to 9924db0 Compare November 20, 2023 12:03
@elchead elchead force-pushed the feat/ci/gh-issue-on-failure branch from 9924db0 to a10c8ea Compare November 20, 2023 13:33
@katexochen katexochen requested a review from 3u13r November 20, 2023 15:43
@elchead elchead requested a review from katexochen November 20, 2023 16:04
katexochen
katexochen approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm. did you start a test run from this branch?

@elchead
Copy link
Contributor Author

elchead commented Nov 21, 2023

code lgtm. did you start a test run from this branch?

@katexochen these were items i created for testing in the e2e manual test:
https://github.com/orgs/edgelesssys/projects/3/views/4?pane=issue&itemId=44827293

3u13r
3u13r previously requested changes Nov 22, 2023
View reviewed changes
.github/actions/gh_create_issue/create_issue.sh Outdated Show resolved Hide resolved
@elchead elchead requested review from 3u13r November 22, 2023 12:38
@elchead elchead merged commit ed22137 into main Nov 22, 2023
4 checks passed
@elchead elchead deleted the feat/ci/gh-issue-on-failure branch November 22, 2023 16:45
elchead added a commit that referenced this pull request Nov 24, 2023
@elchead @katexochen
ci: notify with GH issue + project item on e2e failure (#2607)
1e3b028 
Signed-off-by: Paul Meyer <[email protected]>
Co-authored-by: Paul Meyer <[email protected]>
elchead added a commit that referenced this pull request Nov 24, 2023
@elchead @katexochen
ci: notify with GH issue + project item on e2e failure (#2607)
e38ed82 
Signed-off-by: Paul Meyer <[email protected]>
Co-authored-by: Paul Meyer <[email protected]>
elchead added a commit that referenced this pull request Nov 24, 2023
@elchead @katexochen
ci: notify with GH issue + project item on e2e failure (#2607)
713b752 
Signed-off-by: Paul Meyer <[email protected]>
Co-authored-by: Paul Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elchead @katexochen @3u13r