rfc: Terraform provider #2613
Merged
rfc: Terraform provider #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
requested review from
malt3,
burgerdev,
m1ghtym0,
derpsteb,
3u13r,
elchead,
katexochen,
thomasten,
daniel-weisse and
miampf
✅ Deploy Preview for constellation-docs canceled.
|
elchead
reviewed
Nov 20, 2023
elchead
reviewed
Nov 21, 2023
burgerdev
reviewed
Nov 21, 2023
elchead
reviewed
Nov 22, 2023
elchead
approved these changes
Nov 22, 2023
elchead
approved these changes
Nov 22, 2023
3u13r
requested changes
Nov 22, 2023
daniel-weisse
approved these changes
Nov 22, 2023
malt3
approved these changes
Nov 22, 2023
msanft
force-pushed
the
feat/rfc/terraform-provider-structure
branch
from
c2ac55d to
4045cc0
Compare
Signed-off-by: Moritz Sanft <[email protected]>
Co-authored-by: Adrian Stobbe <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Co-authored-by: Adrian Stobbe <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
feat/rfc/terraform-provider-structure
branch
from
4045cc0 to
e80b8a5
Compare
thomasten
reviewed
Nov 23, 2023
Comment on lines
+45
to
+46
| master_secret = "foo" # updating this would force recreation of the cluster | ||
| init_secret = "bar" # maybe derive from master_secret, updating this would force recreation of the cluster |
There was a problem hiding this comment.
Do I understand correctly that the user generates these secrets and pastes them into this TF config?
If so, is it common to have such secrets in a TF config? Or should they come from input variables, env variables, etc.?
There was a problem hiding this comment.
You could use the Terraform random provider (what we currently do) to generate this, load them from your HashiCorp vault by using the corresponding provider, etc.
I don't think you would expose them in the configuration files usually, but only in the state, which can be stored remotely, etc. and only have a reference to it, e.g. by using the random provider, in the configuration files - But the RFC should be agnostic of where the value comes from actually. When documenting our provider we could mention some recommendations of how secrets can be provisioned.
thomasten
approved these changes
Nov 23, 2023
elchead
added a commit
that referenced
this pull request
Nov 24, 2023
* rfc: Terraform provider Signed-off-by: Moritz Sanft <[email protected]> * fix typo Co-authored-by: Adrian Stobbe <[email protected]> * rfc: annotate fields that force recreation Signed-off-by: Moritz Sanft <[email protected]> * reword "cluster applying" Co-authored-by: Adrian Stobbe <[email protected]> * rfc: resembles -> declares Signed-off-by: Moritz Sanft <[email protected]> * rfc: connect dangling sentence Signed-off-by: Moritz Sanft <[email protected]> * rfc: indicate sensitive state Signed-off-by: Moritz Sanft <[email protected]> * rfc: warn about PVs on recreation Signed-off-by: Moritz Sanft <[email protected]> * rfc: idempotent -> nilpotent Signed-off-by: Moritz Sanft <[email protected]> * rfc: reword deletion Signed-off-by: Moritz Sanft <[email protected]> * rfc: mention resource outputs Signed-off-by: Moritz Sanft <[email protected]> --------- Signed-off-by: Moritz Sanft <[email protected]> Co-authored-by: Adrian Stobbe <[email protected]>
elchead
added a commit
that referenced
this pull request
Nov 24, 2023
* rfc: Terraform provider Signed-off-by: Moritz Sanft <[email protected]> * fix typo Co-authored-by: Adrian Stobbe <[email protected]> * rfc: annotate fields that force recreation Signed-off-by: Moritz Sanft <[email protected]> * reword "cluster applying" Co-authored-by: Adrian Stobbe <[email protected]> * rfc: resembles -> declares Signed-off-by: Moritz Sanft <[email protected]> * rfc: connect dangling sentence Signed-off-by: Moritz Sanft <[email protected]> * rfc: indicate sensitive state Signed-off-by: Moritz Sanft <[email protected]> * rfc: warn about PVs on recreation Signed-off-by: Moritz Sanft <[email protected]> * rfc: idempotent -> nilpotent Signed-off-by: Moritz Sanft <[email protected]> * rfc: reword deletion Signed-off-by: Moritz Sanft <[email protected]> * rfc: mention resource outputs Signed-off-by: Moritz Sanft <[email protected]> --------- Signed-off-by: Moritz Sanft <[email protected]> Co-authored-by: Adrian Stobbe <[email protected]>
4 tasks
elchead
added a commit
that referenced
this pull request
Nov 24, 2023
* rfc: Terraform provider Signed-off-by: Moritz Sanft <[email protected]> * fix typo Co-authored-by: Adrian Stobbe <[email protected]> * rfc: annotate fields that force recreation Signed-off-by: Moritz Sanft <[email protected]> * reword "cluster applying" Co-authored-by: Adrian Stobbe <[email protected]> * rfc: resembles -> declares Signed-off-by: Moritz Sanft <[email protected]> * rfc: connect dangling sentence Signed-off-by: Moritz Sanft <[email protected]> * rfc: indicate sensitive state Signed-off-by: Moritz Sanft <[email protected]> * rfc: warn about PVs on recreation Signed-off-by: Moritz Sanft <[email protected]> * rfc: idempotent -> nilpotent Signed-off-by: Moritz Sanft <[email protected]> * rfc: reword deletion Signed-off-by: Moritz Sanft <[email protected]> * rfc: mention resource outputs Signed-off-by: Moritz Sanft <[email protected]> --------- Signed-off-by: Moritz Sanft <[email protected]> Co-authored-by: Adrian Stobbe <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to determine how the Terraform provider should look in practice. This should not yet discuss implementation details, but rather a high-level overview of what the outcome should be.
Proposed change(s)
Additional info
Checklist