-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: move cli/internal
libraries
#2623
Conversation
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
Signed-off-by: Moritz Sanft <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annotated some files of packages I think should be kept in cli/internal
.
While we are already in the process of moving files, should we consider moving the Helm charts to their own (more globally visible) directory similar to the Terraform files?
I feel that it can sometimes be a bit of hassle to have them deeply nested somewhere in our Go helm code.
Signed-off-by: Moritz Sanft <[email protected]>
Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
We want to transition to a Constellation library that can be consumed by both the CLI and the Terraform provider. The CLI should only contain code that directly interacts with the user and should consume everything else through the library's API. A first step towards this is moving the packages that do not fall under this category from
cli/internal
tointernal
.Proposed change(s)
cli/internal
tointernal
that will also be used by the Terraform provider.internal/constellation
package.Additional info
Checklist