Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Konnectivity migration #2633

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fix Konnectivity migration #2633

merged 2 commits into from
Nov 24, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Nov 22, 2023

Context

Proposed change(s)

  • Allow Cilium to jump minor versions from v1.12 to v1.15
  • If a nodeversion upgrade takes place (from v2.13.x) then remove all the konnectivity setting from the kubeadm config map. Otherwise the KubeAPI pods try to mount e.g. the Konnectivity UDS which we no longer provider through the bootstrapper

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added the no changelog Change won't be listed in release changelog label Nov 22, 2023
@3u13r 3u13r added this to the v2.14.0 milestone Nov 22, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 1fc77d8
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6560859853995000088fa44c
😎 Deploy Preview https://deploy-preview-2633--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3u13r 3u13r force-pushed the fix/upgrade/konnectivity-migration branch from 4a01386 to eb57753 Compare November 22, 2023 19:52
daniel-weisse
daniel-weisse reviewed Nov 23, 2023
View reviewed changes
internal/kubecmd/kubecmd.go Show resolved Hide resolved
internal/kubecmd/kubecmd.go Outdated Show resolved Hide resolved
@3u13r 3u13r requested a review from daniel-weisse November 23, 2023 14:39
@3u13r 3u13r force-pushed the fix/upgrade/konnectivity-migration branch from 639b036 to d0d4133 Compare November 23, 2023 15:23
@3u13r 3u13r force-pushed the fix/upgrade/konnectivity-migration branch from d0d4133 to 1fc77d8 Compare November 24, 2023 11:14
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
internal/helm 54.30% 54.40% ↗️
internal/kubecmd 64.60% 68.50% ↗️

@3u13r 3u13r merged commit 635a5d2 into main Nov 24, 2023
8 checks passed
@3u13r 3u13r deleted the fix/upgrade/konnectivity-migration branch November 24, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@3u13r @daniel-weisse