terraform-provider: add image datasource #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
requested review from
3u13r and
daniel-weisse
and removed request for
derpsteb and
katexochen
msanft
force-pushed
the
feat/terraform-provider/image-datasource
branch
from
1e8ff57 to
bb0473e
Compare
elchead
reviewed
Nov 24, 2023
terraform-provider-constellation/internal/provider/image_data_source.go
Outdated
Show resolved
Hide resolved
terraform-provider-constellation/internal/provider/provider_test.go
Outdated
Show resolved
Hide resolved
elchead
reviewed
Nov 24, 2023
terraform-provider-constellation/internal/provider/image_data_source_test.go
Show resolved
Hide resolved
|
can you rebase? otherwise my PR is hard to review 🙈 |
Rebase to what? I should be up-to-date with |
daniel-weisse
approved these changes
Nov 24, 2023
terraform-provider-constellation/internal/provider/image_data_source.go
Outdated
Show resolved
Hide resolved
elchead
reviewed
Nov 24, 2023
Base automatically changed from
feat/terraform/init-provider-scaffolding
to
main
November 24, 2023 14:58
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
✅ Deploy Preview for constellation-docs canceled.
|
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
Signed-off-by: Moritz Sanft <[email protected]>
msanft
force-pushed
the
feat/terraform-provider/image-datasource
branch
from
4bc35bd to
686f465
Compare
elchead
approved these changes
Nov 27, 2023
| // Save data into Terraform state | ||
| data.Reference = types.StringValue(imageRef) | ||
| // Use a placeholder ID for testing, as per | ||
| data.ID = types.StringValue("placeholder") |
There was a problem hiding this comment.
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the Terraform provider, we need a way to transform a CSP-agnostic image reference to a CSP-specific image reference, which can be used inside the Cluster resource. This is based on #2632.
Proposed change(s)
Additional info
Checklist