Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix service accounts introduced by merge #2652

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

daniel-weisse
Copy link
Member

Context

#2601 moved around some service accounts.
#2629 was not rebased on these changes.
This caused now deleted service accounts to still be used by the CI

Proposed change(s)

  • Swap outdated service accounts for new ones
  • Remove placeholders for the GCP_E2E_PROJECT secret. We decided to not use a hardcoded secret for this in the future as it makes updating the CI difficult

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Nov 28, 2023
@daniel-weisse daniel-weisse added this to the v2.14.0 milestone Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 8cfc126
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6565990b92493f0008c5acbd

@daniel-weisse daniel-weisse changed the title ci: fix serivce accounts introduced my merge ci: fix serivce accounts introduced by merge Nov 28, 2023
@daniel-weisse daniel-weisse merged commit 43f47cc into main Nov 28, 2023
5 checks passed
@daniel-weisse daniel-weisse deleted the fix/ci/constellation-destroy branch November 28, 2023 09:55
@daniel-weisse daniel-weisse changed the title ci: fix serivce accounts introduced by merge ci: fix service accounts introduced by merge Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants