terraform: align infrastructure module attributes

[elchead]

Context

We want to publish the infrastructure and IAM modules with the Constellation release, so that users can use them as a reference setup or directly consume them combined with the Terraform providers resources and data sources. Therefore, their inputs / outputs should be properly named (snake case) and described. Furthermore, the names should be semantically correct and aligned with the input names of the provider.

Proposed change(s)

• Rename and describe fields as necessary.

Additional info

• AB#3599
• E2E Test Daily
• E2E Test Self Managed infrastructure
• E2E Test Upgrade AWS
• E2E Test Upgrade Azure
• E2E Test Upgrade GCP

Checklist

• Add labels (e.g., for changelog category)
• Is PR title adequate for changelog?
• Link to Milestone

[netlify]

✅ Deploy Preview for constellation-docs ready!

Name	Link
🔨 Latest commit	8e54791
🔍 Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/657b1b161df1140009b02a3f
😎 Deploy Preview	https://deploy-preview-2703--constellation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[msanft]

Only left some incomplete feedback for AWS for now as I couldn't attach suggestions to unedited parts of the code (e.g. modules within the infrastructure/aws module). I propose to prepare a commit with some additional changes I'd like to see here so you can cherry-pick it into here.

[daniel-weisse]

We should also run upgrade tests on all csps to make sure the renaming doesnt break anything

[elchead]

I also started self-managed infra and mini

[elchead]

Self-managed is failing:
will fix: https://github.com/edgelesssys/constellation/actions/runs/7194544027/job/19595301298#step:6:3700

[msanft]

So we have at least one upgrade failure here since I renamed some of the output.tf files into the canonical Terraform filename outputs.tf. This is probably not easy to fix without a custom migration in the Constellation CLI, which is why I would say we leave that for now and maybe tackle it in a future version to not increase the failure vector of the changes made within this PR too much.

[daniel-weisse]

since I renamed some of the output.tf files into the canonical Terraform filename outputs.tf

We could fix that by running a pre-upgrade hook to delete the outputs.tf file from the Terraform working dir (the file should be backed up anyway) before running the actual upgrades.
On error/rollback we just restore the old state.

[msanft]

We could fix that by running a pre-upgrade hook to delete the outputs.tf file from the Terraform working dir (the file should be backed up anyway) before running the actual upgrades. On error/rollback we just restore the old state.

Yeah, that would be the kind of migration I roughly had in mind. Still, for me it is unclear whether we want to further increase the spectrum of possible failures by doing so in this release - also looking at the feature freeze planned on friday.

[github-actions]

Coverage report

Package	Old	New	Trend
cli/internal/cloudcmd	64.80%	64.10%	↘️
cli/internal/cmd	58.30%	58.30%	↔️
cli/internal/terraform	72.30%	72.40%	↗️
e2e/internal/upgrade	[no test files]	[no test files]	🚧
internal/config	79.30%	79.30%	↔️
terraform	[no test files]	[no test files]	🚧
terraform-provider-constellation/internal/provider	5.80%	5.80%	🚧