cli: fix upgrades when using outdated Kubernetes patch version #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-weisse
changed the title
daniel-weisse
changed the title
✅ Deploy Preview for constellation-docs canceled.
|
msanft
approved these changes
Dec 14, 2023
elchead
requested changes
Dec 14, 2023
daniel-weisse
force-pushed
the
fix/cli/helm-upgrades
branch
from
dd3e1cc to
af4e4c1
Compare
elchead
approved these changes
Dec 15, 2023
elchead
approved these changes
Dec 15, 2023
daniel-weisse
force-pushed
the
fix/cli/helm-upgrades
branch
from
af4e4c1 to
6bef3ef
Compare
daniel-weisse
force-pushed
the
fix/cli/helm-upgrades
branch
from
6bef3ef to
dc17f74
Compare
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
fix/cli/helm-upgrades
branch
from
dc17f74 to
4410dd9
Compare
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users may choose to not upgrade their Kubernetes version when running a Constellation upgrade.
This includes not upgrading a patch version of Kubernetes.
We use the Kubernetes version set in a user's config to determine which image to use for the Constellation deployed cloud-controller-manager and cluster-autoscaler.
Currently, the CLI incorrectly sets the k8s version to an empty string if a user chooses to apply an upgrade with a no longer supported Kubernetes patch version.
Proposed change(s)
Additional info