Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parallelize upgrade e2e test #2724

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 15, 2023

Context

While working a lot with the e2e test, it became apparent that the curent start-to-feedback time is quite slow. Therefore, the test could be sped up a little.

Proposed change(s)

  • Parallelize building the upgrade target CLI and spinning up the upgrade origin cluster to be concurrent, and then perform the actual e2e test afterwards.

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Dec 15, 2023
@msanft msanft added this to the v2.14.0 milestone Dec 15, 2023
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 9724111
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65aa3155d7d8e60008500964

Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to upload the working dir from the create-cluster job, and download it in the e2e-upgrade job, otherwise we are missing some files to run the upgrade.

We should also either add a terminate-on-failure step to the create-cluster job in case anything goes wrong in that job, or split the terminate step into its own job, which runs if either create-cluster, or e2e-upgrade fails.
If ran as its own job, the terminate action requires access to the working directory, which means we would need to unconditionally upload the working dir from create-cluster, even if a step fails.

.github/workflows/e2e-upgrade.yml Outdated Show resolved Hide resolved
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch 2 times, most recently from 666216e to d8b4b94 Compare December 18, 2023 11:21
@burgerdev burgerdev modified the milestones: v2.14.0, v2.15.0 Dec 18, 2023
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch 3 times, most recently from bd92f6f to 98427f7 Compare December 20, 2023 07:18
@msanft msanft marked this pull request as ready for review December 20, 2023 09:51
@msanft
Copy link
Contributor Author

msanft commented Dec 20, 2023

Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should merge after #2567

@msanft msanft added the blocked Blocked by an external cause label Dec 20, 2023
@msanft
Copy link
Contributor Author

msanft commented Dec 20, 2023

Blocked until we can encrypt multiple-file artifacts

@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch from 4f488a0 to ec1b221 Compare December 21, 2023 17:12
@msanft msanft removed the blocked Blocked by an external cause label Dec 21, 2023
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch from ec1b221 to ccdf3bf Compare December 22, 2023 07:35
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch from c4f7096 to f122705 Compare January 5, 2024 07:54
.github/actions/artifact_download/action.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/e2e-upgrade.yml Outdated Show resolved Hide resolved
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch from f122705 to 03e9197 Compare January 16, 2024 10:00
@msanft msanft force-pushed the feat/ci/parallelize-upgrade-test branch from 0342a7c to 9724111 Compare January 19, 2024 08:22
@msanft msanft merged commit 0030a26 into main Jan 19, 2024
20 checks passed
@msanft msanft deleted the feat/ci/parallelize-upgrade-test branch January 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants