-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: parallelize upgrade e2e test #2724
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to upload the working dir from the create-cluster
job, and download it in the e2e-upgrade
job, otherwise we are missing some files to run the upgrade.
We should also either add a terminate-on-failure step to the create-cluster
job in case anything goes wrong in that job, or split the terminate step into its own job, which runs if either create-cluster
, or e2e-upgrade
fails.
If ran as its own job, the terminate action requires access to the working directory, which means we would need to unconditionally upload the working dir from create-cluster
, even if a step fails.
666216e
to
d8b4b94
Compare
bd92f6f
to
98427f7
Compare
Another E2E Test: https://github.com/edgelesssys/constellation/actions/runs/7273685348 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should merge after #2567
Blocked until we can encrypt multiple-file artifacts |
4f488a0
to
ec1b221
Compare
ec1b221
to
ccdf3bf
Compare
c4f7096
to
f122705
Compare
f122705
to
03e9197
Compare
0342a7c
to
9724111
Compare
Context
While working a lot with the e2e test, it became apparent that the curent start-to-feedback time is quite slow. Therefore, the test could be sped up a little.
Proposed change(s)
Additional info
Checklist