Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions: generate k8s image patches (incl etcd) #2764

Merged
merged 2 commits into from
Dec 21, 2023
Merged

versions: generate k8s image patches (incl etcd) #2764

merged 2 commits into from
Dec 21, 2023

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Dec 21, 2023 •
edited by azure-boards bot
Loading

Context

#2719 introduced Kubernetes component patches that are to be passed to kubeadm during init and upgrade. These patches were manually generated and did not include the etcd component.

Proposed change(s)

  • Add library support for fetching image hashes and generating JSON patches.
  • Use the kubeadm Golang libraries to derive the etcd version for a given k8s version.
  • Include patches in hash-generator.

Additional info

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Dec 21, 2023
@burgerdev burgerdev added this to the v2.15.0 milestone Dec 21, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 96ca1f0
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6584896da3f303000885954c

malt3
malt3 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me!

internal/versions/hash-generator/generate.go Outdated Show resolved Hide resolved
internal/versions/hash-generator/generate.go Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/generate-patches branch from fcb6db5 to abe5f3a Compare December 21, 2023 16:52
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
internal/versions 9.70% 9.70% 🚧
internal/versions/hash-generator 0.00% 0.00% 🚧
terraform-provider-constellation [no test files] [no test files] 🚧

@burgerdev burgerdev merged commit 837b24b into main Dec 21, 2023
8 checks passed
@burgerdev burgerdev deleted the burgerdev/generate-patches branch December 21, 2023 19:56
@flxflx flxflx mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @malt3