Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update asciinema videos #2777

Merged
merged 1 commit into from
Jan 8, 2024
Merged

docs: update asciinema videos #2777

merged 1 commit into from
Jan 8, 2024

Conversation

m1ghtym0
Copy link
Member

Context

The 2.14 release removed the constellation create step from cluster creation workflow. This PR updates the asciinema videos accordingly.

Proposed change(s)

  • Updates all asciinema recordings with a 2.14 run
  • Updates the SVG in the README

Additional info

  • Please be aware that the recordings aren't versioned for the docs. Reading the docs with a version < 2.14 will have "unmatching" videos from now on. This was already the case with < 2.13 when switching from init to apply.
  • Please check if the slightly longer SVG on README works with your browser and doesn't use to much resources (CPU, RAM)

Checklist

  • Update docs
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@m1ghtym0 m1ghtym0 added documentation Improvements or additions to documentation no changelog Change won't be listed in release changelog labels Dec 27, 2023
@m1ghtym0 m1ghtym0 requested a review from thomasten as a code owner December 27, 2023 13:29
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 1d67da9
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/658c26a81a7d1c0008fedeee
😎 Deploy Preview https://deploy-preview-2777--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1ghtym0
Copy link
Member Author

README consumes slightly more CPU now: 26-36% vs. 20-34%

@m1ghtym0 m1ghtym0 requested a review from 3u13r December 27, 2023 15:16
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1ghtym0 m1ghtym0 merged commit 2af34ce into main Jan 8, 2024
6 checks passed
@m1ghtym0 m1ghtym0 deleted the fix/docs/asciinema branch January 8, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants