terraform-provider: require kubernetes and microservice version #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
force-pushed
the
fix/terraform-provider/require-versions
branch
from
875f97d to
fc262e2
Compare
msanft
previously requested changes
Jan 3, 2024
elchead
force-pushed
the
fix/terraform-provider/require-versions
branch
from
fc262e2 to
8fcdccb
Compare
elchead
force-pushed
the
fix/terraform-provider/require-versions
branch
3 times, most recently
from
494472c to
958781c
Compare
|
Running E2E |
elchead
force-pushed
the
fix/terraform-provider/require-versions
branch
from
958781c to
b5b684b
Compare
Coverage report
|
msanft
previously requested changes
Jan 4, 2024
| name = "constell" | ||
| version = "vX.Y.Z" | ||
| kubernetes_version = "vX.Y.Z" | ||
| microservice_version = "vX.Y.Z" |
There was a problem hiding this comment.
shouldn't this be equal to version and thus obsolete?
There was a problem hiding this comment.
no. version refers to the image_version is and is renamed to make this more clear in #2775
msanft
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The provider is currently using a default when no version is specified for these fields. This however leads to an unexpected upgrade state, because new versions defaults, as part of provider upgrades, are not seen as state change by Terraform. Consequently, the new defaults are not applied. This is especially undesired for the microservice version, which should always coincide with the provider version.
Proposed change(s)
breaking changeto make users awareAdditional info
Checklist