cli: support for GCP marketplace images #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
malt3
approved these changes
Jan 4, 2024
daniel-weisse
approved these changes
Jan 8, 2024
|
thomasten
requested changes
Jan 8, 2024
|
can you link a test run? |
Co-authored-by: Thomas Tendyck <[email protected]>
thomasten
reviewed
Jan 8, 2024
terraform-provider-constellation/internal/provider/image_data_source.go
Outdated
Show resolved
Hide resolved
thomasten
approved these changes
Jan 8, 2024
Coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recently, our initial GCP marketplace image (v2.14.0) got approved, which enables us to test the use of GCP marketplace images in Constellation. In consultation of @malt3, we opted for a low-complexity, "dumb" implementation which assumes that all stable images are also uploaded to the public GCP project hosting the marketplace images (which needs to be automated in a subsequent PR), and then just replaces the GCP project name in the image reference if the use of marketplace images is enabled in the config's GCP section. This is sufficient to be billed through the marketplace on GCP.
Proposed change(s)
.provider.gcp.useMarketplaceImage)constellation-imagesproject in the image reference withmpi-edgeless-systems-public, which is the public GCP project that hosts the marketplace images.Additional info
Checklist