image: build and upload as one step #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
malt3
force-pushed
the
feat/image/build-and-upload-as-one-step
branch
2 times, most recently
from
4b0724a to
a4c5a91
Compare
3 tasks
malt3
force-pushed
the
feat/image/build-and-upload-as-one-step
branch
2 times, most recently
from
3ef8b89 to
2e0ad1f
Compare
msanft
force-pushed
the
feat/image/build-and-upload-as-one-step
branch
from
2e0ad1f to
c1e981e
Compare
malt3
force-pushed
the
feat/image/build-and-upload-as-one-step
branch
from
c1e981e to
9ef9d22
Compare
This logic was previously performed in a GitHub Actions workflow using yq. Since every step should now be performed in Bazel, this now needs to happen here.
This implementation will replace the custom Go code in
internal/osimage/{aws|azure|gcp} and still conforms to the same interface.
This rule combines uplosi, the upload command, measurement code and cosign to upload OS images, extract measurements, sign them and upload the measurements.
malt3
force-pushed
the
feat/image/build-and-upload-as-one-step
branch
from
9ef9d22 to
8c02536
Compare
Coverage report
|
msanft
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
GitHub Actions has changed the API for Artifacts. This limits the amount of artifacts per workflow, doesn't allow overwriting artifacts in a Workflow run and changed the way globs are handled.
Since the old API will likely be disabled soon, we have to refactor the image build pipeline.
As a nice bonus, the pipeline is now roughly twice as fast (1h -> 30min).
Proposed change(s)
//image/system:upload_*for uploading imagesAdditional info
Debug image for testing:
Console image for testing:
Command for uploading debug images from your workstation:
bazel run //image/system:upload_debug -- --ref foo --upload-measurements --fake-signChecklist