Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bazel, Go, nix #2824

Merged
merged 6 commits into from
Jan 22, 2024
Merged

deps: bazel, Go, nix #2824

merged 6 commits into from
Jan 22, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Jan 15, 2024 •
edited
Loading

Context

Combined deps update for everything that invalidates the full build cache.

Proposed change(s)

  • deps: update hermetic_cc_toolchain
  • deps: update gazelle and rules_go
  • nix: update flake.lock
  • deps: Go 1.21.6

Related issue

-Unfortunately, we have to ignore a source of leaking go routines, until this is resolved: uber-go/goleak#119

@netlify Netlify
Copy link

netlify bot commented Jan 15, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 0bd35a0
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65a6b6f7fd362700084a3207

@malt3 malt3 marked this pull request as draft January 15, 2024 14:50
@malt3 malt3 force-pushed the deps/toolchains/bazel-go branch from 4d3cfd7 to ab825e4 Compare January 16, 2024 16:54
@malt3
goleak: ignore rules_go SIGTERM handler
0bd35a0 
rules_go added a SIGTERM handler that has a goroutine that survives the scope of the goleak check.
Currently, the best known workaround is to ignore this goroutine.

uber-go/goleak#119
bazel-contrib/rules_go#3749
bazel-contrib/rules_go#3827 (comment)
@malt3 malt3 force-pushed the deps/toolchains/bazel-go branch from ab825e4 to 0bd35a0 Compare January 16, 2024 17:03
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
bootstrapper/internal/clean 100.00% 100.00% ↔️
bootstrapper/internal/diskencryption 76.90% 76.90% ↔️
bootstrapper/internal/initserver 73.70% 73.70% ↔️
bootstrapper/internal/joinclient 88.40% 88.40% ↔️
bootstrapper/internal/kubernetes 74.80% 74.80% ↔️
bootstrapper/internal/kubernetes/k8sapi 13.40% 13.40% 🚧
bootstrapper/internal/kubernetes/kubewaiter 100.00% 100.00% ↔️
cli/internal/cloudcmd 64.10% 64.10% ↔️
cli/internal/cmd 58.50% 58.50% ↔️
cli/internal/terraform 72.40% 72.40% ↔️
csi/cryptmapper 75.90% 75.90% ↔️
csi/kms 70.00% 70.00% ↔️
debugd/internal/debugd/deploy 83.60% 83.60% ↔️
debugd/internal/debugd/metadata 94.10% 94.10% ↔️
debugd/internal/debugd/metadata/cloudprovider 75.90% 75.90% ↔️
debugd/internal/debugd/metadata/fallback 80.00% 80.00% ↔️
debugd/internal/debugd/server 70.70% 70.70% ↔️
debugd/internal/filetransfer 100.00% 100.00% ↔️
debugd/internal/filetransfer/streamer 90.90% 90.90% ↔️
disk-mapper/internal/recoveryserver 89.10% 89.10% ↔️
disk-mapper/internal/rejoinclient 93.10% 93.10% ↔️
disk-mapper/internal/setup 68.90% 68.90% ↔️
disk-mapper/internal/systemd 25.80% 25.80% 🚧
hack/bazel-deps-mirror/internal/bazelfiles 75.00% 75.00% ↔️
hack/bazel-deps-mirror/internal/issues 88.90% 88.90% ↔️
hack/bazel-deps-mirror/internal/mirror 80.20% 80.20% ↔️
hack/bazel-deps-mirror/internal/rules 82.20% 82.20% ↔️
image/measured-boot/extract 84.40% 84.40% ↔️
image/measured-boot/measure 76.70% 76.70% ↔️
internal/api/versionsapi 69.80% 69.80% ↔️
internal/atls 78.60% 78.60% ↔️
internal/attestation/measurements/measurement-generator 0.00% 0.00% 🚧
internal/attestation/vtpm 22.40% 22.40% 🚧
internal/cloud/aws 84.40% 84.40% ↔️
internal/cloud/azure 67.10% 67.10% ↔️
internal/cloud/azureshared 95.60% 95.60% ↔️
internal/cloud/gcp 72.90% 72.90% ↔️
internal/config 79.40% 79.50% ↗️
internal/crypto 69.60% 69.60% ↔️
internal/file 89.40% 89.40% ↔️
internal/grpc/atlscredentials 61.50% 61.50% ↔️
internal/grpc/dialer 100.00% 100.00% ↔️
internal/imagefetcher 74.50% 74.50% ↔️
internal/kms/kms/cluster 75.00% 75.00% ↔️
internal/kms/kms/internal 86.40% 86.40% ↔️
internal/kms/setup 36.20% 36.20% 🚧
internal/kms/storage/memfs 100.00% 100.00% ↔️
internal/kms/uri 68.50% 68.50% ↔️
internal/nodestate 100.00% 100.00% ↔️
internal/osimage/secureboot 79.20% 79.20% ↔️
internal/retry 64.30% 64.30% ↔️
internal/role 70.60% 70.60% ↔️
internal/sigstore 43.00% 43.00% 🚧
internal/staticupload 79.20% 79.20% ↔️
internal/versions/hash-generator 0.00% 0.00% 🚧
joinservice/internal/kms 85.70% 85.70% ↔️
joinservice/internal/kubeadm 76.10% 76.10% ↔️
joinservice/internal/kubernetes 6.90% 6.90% 🚧
joinservice/internal/kubernetesca 81.60% 81.60% ↔️
joinservice/internal/server 79.20% 79.20% ↔️
joinservice/internal/watcher 73.70% 73.70% ↔️
keyservice/internal/server 61.90% 61.90% ↔️
operators/constellation-node-operator/internal/executor 89.50% 89.50% ↔️
s3proxy/internal/kms 85.70% 85.70% ↔️
verify/server 95.40% 95.40% ↔️

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
bootstrapper/internal/clean 100.00% 100.00% ↔️
bootstrapper/internal/diskencryption 76.90% 76.90% ↔️
bootstrapper/internal/initserver 73.70% 73.70% ↔️
bootstrapper/internal/joinclient 88.40% 88.40% ↔️
bootstrapper/internal/kubernetes 74.80% 74.80% ↔️
bootstrapper/internal/kubernetes/k8sapi 13.40% 13.40% 🚧
bootstrapper/internal/kubernetes/kubewaiter 100.00% 100.00% ↔️
cli/internal/cloudcmd 64.10% 64.10% ↔️
cli/internal/cmd 58.50% 58.50% ↔️
cli/internal/terraform 72.40% 72.40% ↔️
csi/cryptmapper 75.90% 75.90% ↔️
csi/kms 70.00% 70.00% ↔️
debugd/internal/debugd/deploy 83.60% 83.60% ↔️
debugd/internal/debugd/metadata 94.10% 94.10% ↔️
debugd/internal/debugd/metadata/cloudprovider 75.90% 75.90% ↔️
debugd/internal/debugd/metadata/fallback 80.00% 80.00% ↔️
debugd/internal/debugd/server 70.70% 70.70% ↔️
debugd/internal/filetransfer 100.00% 100.00% ↔️
debugd/internal/filetransfer/streamer 90.90% 90.90% ↔️
disk-mapper/internal/recoveryserver 89.10% 89.10% ↔️
disk-mapper/internal/rejoinclient 93.10% 93.10% ↔️
disk-mapper/internal/setup 68.90% 68.90% ↔️
disk-mapper/internal/systemd 25.80% 25.80% 🚧
hack/bazel-deps-mirror/internal/bazelfiles 75.00% 75.00% ↔️
hack/bazel-deps-mirror/internal/issues 88.90% 88.90% ↔️
hack/bazel-deps-mirror/internal/mirror 80.20% 80.20% ↔️
hack/bazel-deps-mirror/internal/rules 82.20% 82.20% ↔️
image/measured-boot/extract 84.40% 84.40% ↔️
image/measured-boot/measure 76.70% 76.70% ↔️
internal/api/versionsapi 69.80% 69.80% ↔️
internal/atls 78.60% 78.60% ↔️
internal/attestation/measurements/measurement-generator 0.00% 0.00% 🚧
internal/attestation/vtpm 22.40% 22.40% 🚧
internal/cloud/aws 84.40% 84.40% ↔️
internal/cloud/azure 67.10% 67.10% ↔️
internal/cloud/azureshared 95.60% 95.60% ↔️
internal/cloud/gcp 72.90% 72.90% ↔️
internal/config 79.40% 79.40% ↔️
internal/crypto 69.60% 69.60% ↔️
internal/file 89.40% 89.40% ↔️
internal/grpc/atlscredentials 61.50% 61.50% ↔️
internal/grpc/dialer 100.00% 100.00% ↔️
internal/imagefetcher 74.50% 74.50% ↔️
internal/kms/kms/cluster 75.00% 75.00% ↔️
internal/kms/kms/internal 86.40% 86.40% ↔️
internal/kms/setup 36.20% 36.20% 🚧
internal/kms/storage/memfs 100.00% 100.00% ↔️
internal/kms/uri 68.50% 68.50% ↔️
internal/nodestate 100.00% 100.00% ↔️
internal/osimage/secureboot 79.20% 79.20% ↔️
internal/retry 64.30% 64.30% ↔️
internal/role 70.60% 70.60% ↔️
internal/sigstore 43.00% 43.00% 🚧
internal/staticupload 79.20% 79.20% ↔️
internal/versions/hash-generator 0.00% 0.00% 🚧
joinservice/internal/kms 85.70% 85.70% ↔️
joinservice/internal/kubeadm 76.10% 76.10% ↔️
joinservice/internal/kubernetes 6.90% 6.90% 🚧
joinservice/internal/kubernetesca 81.60% 81.60% ↔️
joinservice/internal/server 79.20% 79.20% ↔️
joinservice/internal/watcher 73.70% 73.70% ↔️
keyservice/internal/server 61.90% 61.90% ↔️
operators/constellation-node-operator/internal/executor 89.50% 89.50% ↔️
s3proxy/internal/kms 85.70% 85.70% ↔️
verify/server 95.40% 95.40% ↔️

@malt3 malt3 marked this pull request as ready for review January 22, 2024 08:54
@katexochen katexochen removed their request for review January 22, 2024 09:09
@malt3 malt3 merged commit 3a57530 into main Jan 22, 2024
11 checks passed
@malt3 malt3 deleted the deps/toolchains/bazel-go branch January 22, 2024 12:12
@elchead elchead added the no changelog Change won't be listed in release changelog label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r 3u13r is a code owner

@elchead elchead Awaiting requested review from elchead elchead is a code owner

@thomasten thomasten Awaiting requested review from thomasten thomasten is a code owner

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default ignorelist entry for rules_go SIGTERM handler
3 participants
@malt3 @daniel-weisse @elchead