ci: fix upload CLI path line splitting #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
This reverts commit 897703a.
msanft
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Approving under the premise of https://github.com/edgelesssys/constellation/actions/runs/7707908660 being successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The action for encrypting artifacts merged in #2567 and it's reversal introduced a bug here, as one requires multiple upload targets to split by spaces, and one by newlines. The reversal only changed the action path, but not the operator concatenating multiple lines in the upload targets, causing the upload to fail.
Proposed change(s)
|, which concatenates the lines with\ns, as required by actions/upload-artifact.Checklist