Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workspace related errors when setting up k8s version for test #2891

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Feb 5, 2024

Context

Determining the default Kubernetes version for the test failed, which was no caught by the test, since the relevant command was executed in a subshell.

Proposed change(s)

  • Properly fail if the command in the subshell failed
  • Replace relative paths with github workspace absolute paths

Related issue

Additional info

Terraform e2e tests:

Signed-off-by: Daniel Weiße <[email protected]>
@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Feb 5, 2024
@daniel-weisse daniel-weisse added this to the v2.16.0 milestone Feb 5, 2024
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit dd8a180
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65c0bdcc8d85d100081a2ff9

@daniel-weisse daniel-weisse force-pushed the fix/ci/terraform-k8s-version branch from b7feeae to 2dfb36f Compare February 5, 2024 09:40
Signed-off-by: Daniel Weiße <[email protected]>
@daniel-weisse daniel-weisse force-pushed the fix/ci/terraform-k8s-version branch from 9d82fe1 to dd8a180 Compare February 5, 2024 10:51
@daniel-weisse daniel-weisse requested a review from msanft February 5, 2024 12:21
@daniel-weisse daniel-weisse merged commit f21252c into main Feb 5, 2024
7 of 8 checks passed
@daniel-weisse daniel-weisse deleted the fix/ci/terraform-k8s-version branch February 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants