Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make instance type configurable for provider sample #2893

Merged
merged 2 commits into from
Feb 5, 2024
Merged

ci: make instance type configurable for provider sample #2893

merged 2 commits into from
Feb 5, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Feb 5, 2024 •
edited
Loading

Context

  1. Terraform provider test for Azure TDX was using the default instance type for SEV-SNP resulting in failed initialization of the cluster.
  2. Terraform provider test tries to upgrade TDX images to SEV-SNP images

Proposed change(s)

  • Make instance type configurable for provider sample
  • Select the correct instance type for TDX e2e test
  • TODO: Fix image upgrade issue

Additional info

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit cba0e55
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65c0ec7469261b000802aa43

@msanft msanft changed the title Make default instance type configurable for provider sample ci: make default instance type configurable for provider sample Feb 5, 2024
@msanft msanft changed the title ci: make default instance type configurable for provider sample ci: make instance type configurable for provider sample Feb 5, 2024
@msanft msanft added this to the v2.16.0 milestone Feb 5, 2024
@msanft msanft added the no changelog Change won't be listed in release changelog label Feb 5, 2024
elchead
elchead approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm when the test is green.

@daniel-weisse daniel-weisse merged commit 64c32c2 into main Feb 5, 2024
7 checks passed
@daniel-weisse daniel-weisse deleted the fix/ci/terraform-default-instance-type branch February 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@elchead elchead elchead approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-weisse @elchead @msanft