Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prevent duplicate artifact naming in same workflow #2903

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Feb 12, 2024

Context

Our weekly tests had multiple different workflows that uploaded to the same artifact name, overwriting it for all workflows, which was not intended behavior.
Additionally, the actions/upload-artifact@v4 action now throws an error when uploading artifacts with the same name in one workflow run.

Proposed change(s)

  • Use workflow unique name for CLI binary in upgrade workflow
  • Skip unnecessary Terraform module upload in provider example test

Related issue

Additional info

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Feb 12, 2024
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 3712c4c
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65c9d2b9d0c19a00086bef40

@daniel-weisse daniel-weisse marked this pull request as ready for review February 12, 2024 08:38
@daniel-weisse daniel-weisse merged commit c5b17fb into main Feb 12, 2024
10 checks passed
@daniel-weisse daniel-weisse deleted the fix/ci/duplicate-artifact-name branch February 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants