Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: collect debug logs in file #2906

Merged
merged 16 commits into from
Feb 21, 2024
Merged

cli: collect debug logs in file #2906

merged 16 commits into from
Feb 21, 2024

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Feb 13, 2024

Context

Collect debug information of constellation apply in a file called constellation-debug.log, even when --debug is not set. This is useful for debugging purposes if --debug wasn't set.

Proposed change(s)

  • add a function logDebug in apply.go that logs to stdout if --debug is set and always logs to constellation-debug.log

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@miampf miampf added the no changelog Change won't be listed in release changelog label Feb 13, 2024
@miampf miampf added this to the v2.16.0 milestone Feb 13, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 13, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 407db06
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65d5eb6c4283fb0008da7f8a

@miampf miampf marked this pull request as ready for review February 13, 2024 14:14
@miampf miampf requested a review from derpsteb as a code owner February 13, 2024 14:14
@miampf miampf force-pushed the collect-debug-logs branch from ead61ed to 4af622a Compare February 14, 2024 12:53
@miampf miampf requested a review from daniel-weisse February 14, 2024 14:10
daniel-weisse
daniel-weisse reviewed Feb 14, 2024
View reviewed changes
internal/constants/constants.go Outdated Show resolved Hide resolved
cli/internal/cmd/apply.go Outdated Show resolved Hide resolved
@miampf miampf force-pushed the collect-debug-logs branch from e91474a to 036c6b9 Compare February 19, 2024 12:25
@miampf miampf requested a review from malt3 as a code owner February 19, 2024 13:43
@miampf miampf requested a review from daniel-weisse February 19, 2024 13:45
@miampf miampf force-pushed the collect-debug-logs branch from 2b237d5 to c30d1a6 Compare February 19, 2024 14:37
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 58.80% 58.50% ↘️
internal/constants [no test files] [no test files] 🚧

@miampf miampf force-pushed the collect-debug-logs branch from c30d1a6 to f35fa87 Compare February 19, 2024 15:19
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 58.80% 58.50% ↘️
internal/constants [no test files] [no test files] 🚧

@miampf miampf force-pushed the collect-debug-logs branch from f35fa87 to 407db06 Compare February 21, 2024 12:24
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 43.40% 43.20% ↘️
internal/constants 0.00% 0.00% 🚧

@miampf miampf merged commit 96c5980 into main Feb 21, 2024
10 checks passed
@miampf miampf deleted the collect-debug-logs branch February 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

@malt3 malt3 malt3 approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@miampf @malt3 @daniel-weisse