Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use collision resistant name for Terraform e2e test #2967

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Mar 4, 2024

Context

The Terraform e2e test uses the last 3 digits of the workflow run for various resource names.
This causes issues when running more than one test on the same CSP in the same workflow.
Notably this occurs for azure-tdx and azure-sev-snp in our weekly tests.

Proposed change(s)

  • Use the same collision resistant naming scheme as used by our other e2e tests

Related issue

Checklist

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label Mar 4, 2024
@daniel-weisse daniel-weisse added this to the v2.17.0 milestone Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 07881e7
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/65e5a92e6cf73a00083ac5d0

@daniel-weisse daniel-weisse force-pushed the fix/ci/terraform-name branch from ff05167 to 1396017 Compare March 4, 2024 09:08
@daniel-weisse daniel-weisse marked this pull request as ready for review March 4, 2024 11:44
@daniel-weisse daniel-weisse merged commit d5b3d4f into main Mar 4, 2024
7 checks passed
@daniel-weisse daniel-weisse deleted the fix/ci/terraform-name branch March 4, 2024 12:48
malt3 pushed a commit that referenced this pull request Mar 11, 2024
* Use collision resistant name for Terraform e2e test
* Remove test suffix from Terraform provider examples

---------

Signed-off-by: Daniel Weiße <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants