ci: fix unwanted license checks for some e2e test configs #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
elchead
approved these changes
Mar 22, 2024
|
After checking which e2e tests I need to run, I think I made the change at the wrong place. The line in the e2e_test action actually seems to be redundant with another one in the constellation_create action. Instead, I think it must be added in two other workflows that don't use the e2e_test action. I'll run the workflows and verify this. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License check is supposed to be disabled for e2e tests, but it wasn't for some test configs, e.g., TF provider.
Checklist