Support SEV-SNP on GCP #3011

msanft · 2024-04-04T15:11:48Z

Context

GCP released a public preview for AMD SEV-SNP, which means that we can now use SEV-SNP on GCP in Constellation. This PR enables support for it on our side. It does not yet replace GCP SEV-ES as the default method for GCP on Constellation, which we can do once it's GA and prove to be stable to us in Constellation.

Proposed change(s)

Add GCP SEV-SNP attestation logic, with most of the code being "borrowed" from our AWS SEV-SNP implementation, with some changes, e.g. as GCP provides a TPM endorsement key. A detailed description of how the attestation works can be found here. This change also affects other CSPs that rely on vTPMs, as it changes our vTPM attestation scheme to always include a hash of the InstanceInfo within the TPMs attestation report, which is necessary for GCP to bind the TEE attestation to the TPM attestation, and should not affect security on other CSPs.
Add GCP SEV-SNP to our CI E2E-test matrices.
Add auto-generated docs reference for GCP SEV-SNP. I explicitly did not mention GCP SEV-SNP in the docs so far, as I'd like to first prove stability through some weeks of unit tests.

Additional info

AB#3894, AB#4024
I tried to split up this PR into digestible chunks, so feel free to only review the sections that you can/want review, or for which you are a CODEOWNER.
Measurements for GCP SEV-SNP should be automatically created through the CI once the scheduled OS image build runs. For now, testing can be done with a fixed 0 PCR 15.

Checklist

Run the E2E tests that are relevant to this PR's changes
Update docs
Add labels (e.g., for changelog category)
Is PR title adequate for changelog?
Link to Milestone

netlify · 2024-04-04T15:14:09Z

✅ Deploy Preview for constellation-docs canceled.

Name	Link
🔨 Latest commit	`2129781`
🔍 Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/661e86f94cf17600089f1b0d

elchead · 2024-04-05T12:42:52Z

Testing the provider:
https://github.com/edgelesssys/constellation/actions/runs/8569840235
-> the new cc_technology variable logic is missing in the TF provider template

Looked at the TF + config related code. Lgtm besides the open points

cli/internal/cmd/verify.go

docs/docs/overview/clouds.md

internal/attestation/gcp/snp/validator.go

internal/config/gcp.go

terraform-provider-constellation/internal/provider/attestation_data_source_test.go

terraform-provider-constellation/internal/provider/convert.go

internal/config/gcp.go

internal/config/config.go

msanft · 2024-04-05T13:17:00Z

Testing the provider:
https://github.com/edgelesssys/constellation/actions/runs/8569840235

Won't work yet, as measurements are not yet available.

malt3 · 2024-04-08T09:08:23Z

I'm unable to review in the short term. I'll remove myself as a reviewer for now.

elchead

Code lgtm.

I understand that firmware version verification is currently missing (values are set to 0) and that it will be added as part of
https://dev.azure.com/Edgeless/Edgeless/_workitems/edit/4024

This will also be needed to support the attestation data source in the provider.

When will the OS measurements be available?

Once they are there, we should also add SNP to the weekly TF provider example matrix.

thomasten

some nits

.github/actions/constellation_create/action.yml

internal/config/gcp.go

internal/attestation/vtpm/attestation.go

internal/attestation/gcp/gcp.go

internal/attestation/gcp/es/es.go

internal/attestation/gcp/snp/snp.go

internal/attestation/gcp/snp/issuer.go

internal/attestation/gcp/snp/validator.go

internal/attestation/gcp/snp/issuer.go

msanft · 2024-04-10T15:05:49Z

@daniel-weisse could you take a look at the attestation again?

daniel-weisse

Looks mostly good to me now.
Opened a PR to address some things we talked about in person: #3025

internal/attestation/gcp/snp/issuer.go

internal/attestation/gcp/snp/validator.go

elchead · 2024-04-13T17:30:10Z

the gcp provider is not yet supported in the upload.go. Furthermore, we should probably trigger the workflow once with cache-window-size to put a valid version into the api.
Afterwards, the fetcher needs to be integrated in the CLI. I think it makes sense to defer this for a separate PR.

Co-authored-by: Daniel Weiße <[email protected]>

…_data_source_test.go Co-authored-by: Adrian Stobbe <[email protected]>

* Make sure SNP ARK is always loaded from config, or fetched from AMD KDS * GCP: Set validator `reportData` correctly --------- Signed-off-by: Daniel Weiße <[email protected]> Co-authored-by: Moritz Sanft <[email protected]>

Signed-off-by: Moritz Sanft <[email protected]>

…GCP SEV-SNP

github-actions · 2024-04-16T14:19:50Z

Coverage report

Package	Old	New	Trend
cli/internal/cloudcmd	18.70%	19.00%	↗️
cli/internal/cmd	42.70%	41.10%	↘️
cli/internal/terraform	57.30%	56.80%	↘️
internal/api/attestationconfigapi	24.20%	24.00%	↘️
internal/api/attestationconfigapi/cli	0.00%	0.00%	🚧
internal/attestation/aws/snp	8.30%	8.20%	↘️
internal/attestation/azure/snp	8.40%	8.20%	↘️
internal/attestation/choose	8.50%	8.30%	↘️
internal/attestation/gcp	12.10%	0.00%	↘️
internal/attestation/gcp/es	0.00%	12.30%	🆕
internal/attestation/gcp/snp	0.00%	0.00%	🆕
internal/attestation/measurements	41.10%	40.70%	↘️
internal/attestation/measurements/measurement-generator	0.60%	0.60%	🚧
internal/attestation/snp	20.80%	20.30%	↘️
internal/attestation/variant	0.00%	0.00%	🚧
internal/attestation/vtpm	5.30%	5.20%	↘️
internal/config	68.60%	67.90%	↘️
internal/constellation/state	74.30%	73.30%	↘️
measurement-reader/cmd	0.00%	0.00%	🚧
terraform-provider-constellation/internal/provider	4.00%	3.60%	↘️

msanft added the feature This introduces new functionality label Apr 4, 2024

msanft added this to the v2.17.0 milestone Apr 4, 2024

msanft requested review from malt3 and 3u13r April 4, 2024 15:11

msanft requested review from elchead, daniel-weisse, derpsteb and thomasten as code owners April 4, 2024 15:11

msanft force-pushed the feat/gcp-sev-snp branch 3 times, most recently from 39a3f67 to 31edeaf Compare April 5, 2024 12:07

daniel-weisse reviewed Apr 5, 2024

View reviewed changes

cli/internal/cmd/verify.go Outdated Show resolved Hide resolved

docs/docs/overview/clouds.md Outdated Show resolved Hide resolved

internal/attestation/gcp/snp/validator.go Show resolved Hide resolved

internal/config/gcp.go Show resolved Hide resolved

elchead reviewed Apr 5, 2024

View reviewed changes

malt3 removed their request for review April 8, 2024 09:08

msanft requested review from daniel-weisse and elchead April 8, 2024 09:35

elchead approved these changes Apr 9, 2024

View reviewed changes

thomasten reviewed Apr 9, 2024

View reviewed changes

msanft requested a review from thomasten April 10, 2024 11:40

daniel-weisse reviewed Apr 10, 2024

View reviewed changes

internal/attestation/gcp/snp/issuer.go Outdated Show resolved Hide resolved

daniel-weisse reviewed Apr 12, 2024

View reviewed changes

internal/attestation/gcp/snp/issuer.go Outdated Show resolved Hide resolved

internal/attestation/gcp/snp/validator.go Outdated Show resolved Hide resolved

internal/attestation/gcp/snp/validator.go Outdated Show resolved Hide resolved

daniel-weisse approved these changes Apr 12, 2024

View reviewed changes

msanft force-pushed the feat/gcp-sev-snp branch 2 times, most recently from 395531e to 52dac84 Compare April 15, 2024 08:03

msanft and others added 24 commits April 16, 2024 14:02

attestation: add GCP SEV-SNP attestation logic

afeac3a

gcp: factor out common logic

57498a3

choose: add GCP SEV-SNP

68037cf

cli: add TF variable passthrough for GCP SEV-SNP variables

4298fcf

cli: support GCP SEV-SNP for constellation verify

640f6c4

Adjust usage of GCP SEV-SNP throughout codebase

cb543c7

ci: add GCP SEV-SNP

25e1eca

terraform-provider: support GCP SEV-SNP

b7fe2ef

docs: add GCP SEV-SNP reference

2ecffaf

linter fixes

3c07430

gcp: only run test with TPM simulator

ea897ba

gcp: remove nonsense test

aec00b2

Update cli/internal/cmd/verify.go

1657b12

Co-authored-by: Daniel Weiße <[email protected]>

Update docs/docs/overview/clouds.md

75be502

Co-authored-by: Daniel Weiße <[email protected]>

Update terraform-provider-constellation/internal/provider/attestation…

bea33f3

…_data_source_test.go Co-authored-by: Adrian Stobbe <[email protected]>

linter fixes

55d8658

terraform_provider: correctly pass down CC technology

b4811b8

config: mark attestationconfigapi as unimplemented

f7ce3d9

gcp: fix comments and typos

5f14a82

snp: use nonce and PK hash in SNP report

4e3582e

snp: ensure we never use ARK supplied by Issuer (#3025)

500196d

* Make sure SNP ARK is always loaded from config, or fetched from AMD KDS * GCP: Set validator `reportData` correctly --------- Signed-off-by: Daniel Weiße <[email protected]> Co-authored-by: Moritz Sanft <[email protected]>

attestationconfigapi: add GCP to uploading

282216d

snp: use correct cert

694c8b1

Signed-off-by: Moritz Sanft <[email protected]>

terraform-provider: enable fetching of attestation config values for …

8fb087d

…GCP SEV-SNP

msanft force-pushed the feat/gcp-sev-snp branch from d84d765 to 8fb087d Compare April 16, 2024 12:03

linter fixes

2129781

msanft merged commit 913b09a into main Apr 16, 2024
13 of 14 checks passed

msanft deleted the feat/gcp-sev-snp branch April 16, 2024 16:13

daniel-weisse mentioned this pull request Jun 5, 2024

dev-docs: add bare-metal setup #3126

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support SEV-SNP on GCP #3011

Support SEV-SNP on GCP #3011

msanft commented Apr 4, 2024 •

edited

Loading

netlify bot commented Apr 4, 2024 •

edited

Loading

elchead commented Apr 5, 2024 •

edited

Loading

msanft commented Apr 5, 2024

malt3 commented Apr 8, 2024

elchead left a comment •

edited

Loading

thomasten left a comment

msanft commented Apr 10, 2024

daniel-weisse left a comment

elchead commented Apr 13, 2024

github-actions bot commented Apr 16, 2024

Support SEV-SNP on GCP #3011

Support SEV-SNP on GCP #3011

Conversation

msanft commented Apr 4, 2024 • edited Loading

Context

Proposed change(s)

Additional info

Checklist

netlify bot commented Apr 4, 2024 • edited Loading

✅ Deploy Preview for constellation-docs canceled.

elchead commented Apr 5, 2024 • edited Loading

msanft commented Apr 5, 2024

malt3 commented Apr 8, 2024

elchead left a comment • edited Loading

Choose a reason for hiding this comment

thomasten left a comment

Choose a reason for hiding this comment

msanft commented Apr 10, 2024

daniel-weisse left a comment

Choose a reason for hiding this comment

elchead commented Apr 13, 2024

github-actions bot commented Apr 16, 2024

Coverage report

msanft commented Apr 4, 2024 •

edited

Loading

netlify bot commented Apr 4, 2024 •

edited

Loading

elchead commented Apr 5, 2024 •

edited

Loading

elchead left a comment •

edited

Loading