ci: add error handling to e2e windows liveness probe #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for constellation-docs canceled.
|
* More output when waiting for nodes to get ready * Create unique resource group name for Windows e2e test * Push container images on windows CLI build to fix e2e test --------- Signed-off-by: Daniel Weiße <[email protected]>
|
Quick e2e test: https://github.com/edgelesssys/constellation/actions/runs/8643553484 Otherwise looks good to me |
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The liveness probe should not print "All nodes are ready!" after an unsuccessful call to kubectl. Instead, it should retry the command after the specified time.
Proposed change(s)
Related issue
Additional info
Checklist