Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: correctly clean up failed windows e2e tests #3059

Merged
merged 10 commits into from
May 3, 2024
Merged

Conversation

miampf
Copy link
Contributor

@miampf miampf commented May 2, 2024

Context

Failed Windows E2E tests may not be cleaned up correctly.

Proposed change(s)

  • If termination of the cluster/destruction of the IAM configuration using terraform fails, delete all resource groups using the azure CLI

Additional Info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?

@miampf miampf added the no changelog Change won't be listed in release changelog label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit e80e997
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6634bad0efb633000891d596

@miampf miampf requested a review from daniel-weisse May 2, 2024 15:01
@miampf miampf marked this pull request as ready for review May 2, 2024 15:01
Copy link
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

.github/workflows/e2e-windows.yml Outdated Show resolved Hide resolved
@miampf miampf force-pushed the fix-windows-cleanup branch from 2b09cfe to 86b639d Compare May 3, 2024 10:20
@miampf miampf merged commit bd26cb5 into main May 3, 2024
8 checks passed
@miampf miampf deleted the fix-windows-cleanup branch May 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants