Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update all Go dependencies #3071

Merged
merged 6 commits into from
May 8, 2024
Merged

deps: update all Go dependencies #3071

merged 6 commits into from
May 8, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented May 8, 2024

Context

Proposed change(s)

  • Update all Go dependencies
  • Fix usage of invalid validation tags in Config validation
    • Usage of dive tag was always wrong for anything not a map, slice, or array, but didnt error
    • Usage of len also never properly worked for custom types. We only did this in one case while not using it in other similar cases, so I removed it
  • Replace usage of deprecated docker types
  • Group dependency upgrades for Go in one PR through renovate

Checklist

@daniel-weisse daniel-weisse added the dependencies Pull requests that update a dependency file label May 8, 2024
@github-actions github-actions bot requested a review from 3u13r May 8, 2024 12:37
Copy link

netlify bot commented May 8, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 15cdfe0
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/663b891b820b7d0008ae6105

Copy link
Contributor

github-actions bot commented May 8, 2024

Coverage report

Package Old New Trend
bootstrapper/initproto 0.00% 0.00% 🚧
cli/internal/libvirt 0.00% 0.00% 🚧
debugd/service 0.00% 0.00% 🚧
disk-mapper/recoverproto 0.00% 0.00% 🚧
internal/config 68.00% 68.00% ↔️
internal/versions/components 44.30% 44.30% 🚧
joinservice/joinproto 0.00% 0.00% 🚧
keyservice/keyserviceproto 0.00% 0.00% 🚧
upgrade-agent/upgradeproto 0.00% 0.00% 🚧
verify/verifyproto 0.00% 0.00% 🚧

@daniel-weisse daniel-weisse marked this pull request as ready for review May 8, 2024 14:35
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The TF tests seem unrelated (and flaky)

@3u13r 3u13r merged commit 9def35e into main May 8, 2024
19 of 20 checks passed
@3u13r 3u13r deleted the deps/go/mod branch May 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants