Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin crane and npm dependencies #3477

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Pin crane and npm dependencies #3477

merged 4 commits into from
Nov 20, 2024

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Nov 11, 2024 •
edited
Loading

Context

OpenSSF's scorecard found 2 places where dependencies are not pinned. This fixes those places.

Proposed change(s)

  • Pin crane install by latest release commit
  • Use package lock to pin npm dependencies, use npm ci to not override the package lock.

Checklist

@3u13r 3u13r added the no changelog Change won't be listed in release changelog label Nov 11, 2024
@3u13r 3u13r added this to the v2.20.0 milestone Nov 11, 2024
@3u13r 3u13r requested review from katexochen and msanft November 11, 2024 12:09
@3u13r 3u13r requested a review from thomasten as a code owner November 11, 2024 12:09
@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs ready!

Name Link
🔨 Latest commit 009e044
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/673dd92945b12900082e03c5
😎 Deploy Preview https://deploy-preview-3477--constellation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3u13r 3u13r marked this pull request as draft November 11, 2024 14:30
@3u13r 3u13r marked this pull request as ready for review November 20, 2024 17:33
@3u13r 3u13r merged commit 521ff0d into main Nov 20, 2024
10 checks passed
@3u13r 3u13r deleted the euler/ref/pin-crane-and-npm branch November 20, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@thomasten thomasten thomasten approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@3u13r @thomasten @msanft