Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: allow autologin on TTY1 for STACKIT cloud #3499

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Nov 26, 2024

Context

Serial console autologin is currently not working on STACKIT, for several reasons:

  • Unlike other clouds, STACKIT serial console is launched on tty1 rather than ttyS0.
  • We additionally configure tty0 and ttyS1 on STACKIT, which do not exist to the best of my knowledge.
  • We tried to enable serial-getty@tty0, which would have been wrong even if it were tty1 due to baud rate settings etc.

It's worth noting that systemd sets up the getty@%I.service automatically based on the console= kernel parameter, so we should only have to pass this param and configure the drop-in file for autologin.

Proposed change(s)

  • Add a getty@tty1 drop-in similar to the serial-getty@ttyS0.
  • Use the same console=tty1 console=ttyS0 parameters for all CSPs.
  • Rename the constellation.(debug|console) parameters to constel.(debug|console) for consistency.

Additional info

Checklist

@burgerdev burgerdev added bug fix Fixing a bug needs backport This PR needs to be backported to a previous release labels Nov 26, 2024
@burgerdev burgerdev added this to the v2.20.0 milestone Nov 26, 2024
@burgerdev burgerdev requested a review from msanft November 26, 2024 15:44
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 0eacf14
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6745ecf2bd56b60008304441

@burgerdev burgerdev marked this pull request as ready for review November 26, 2024 18:58
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@burgerdev burgerdev merged commit 6d7f687 into main Nov 27, 2024
45 checks passed
@burgerdev burgerdev deleted the burgerdev/console branch November 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a bug needs backport This PR needs to be backported to a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants