Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: drop REST API workaround for SEV-SNP GCP instances #3544

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 11, 2024

Context

Previously, we couldn't just rely on our copy-based approach to generate instance templates for target instance groups on GCP SEV-SNP upgrades, as their client library didn't expose the confidential_instance_type field that specifies whether an SEV or SEV-SNP VM should be created. We always received SEV VMs, as this was the default. Obviously, this broke SEV-SNP upgrades. Now, they've incorporated the field in v1.29.0 of their client library, which we're already on, so we can just drop the workaround commit.

This reverts commit effb086.

Related Issue: googleapis/google-cloud-go#10873

Proposed change(s)

  • Revert the workaround commit, going back to the non-REST approach.

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Dec 11, 2024
@msanft msanft added this to the v2.21.0 milestone Dec 11, 2024
@msanft msanft requested a review from daniel-weisse December 11, 2024 11:47
@msanft msanft requested a review from 3u13r as a code owner December 11, 2024 11:47
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit b816af5
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67597c62e951f400084b941a

@msanft msanft force-pushed the msanft/operator/gcp-drop-rest branch from 235a61b to b816af5 Compare December 11, 2024 11:49
Copy link
Contributor

Coverage report

Package Old New Trend
operators/constellation-node-operator/internal/cloud/gcp/client 80.20% 80.30% ↗️

@msanft msanft merged commit be1deb7 into main Dec 11, 2024
16 checks passed
@msanft msanft deleted the msanft/operator/gcp-drop-rest branch December 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants