Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only write STACKIT configuration if STACKIT test runs #3559

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 20, 2024

Context

In #3556, we unconditionally write the STACKIT configuration to the config file used to create the cluster in the e2e tests. This causes all non-STACKIT tests to fail, as 2 CSPs will be defined in the configuration. An example can be seen here.

Proposed change(s)

  • Only write the STACKIT configuration if a STACKIT test should run.

Additional info

Checklist

  • Run the E2E tests that are relevant to this PR's changes
  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@msanft msanft added the no changelog Change won't be listed in release changelog label Dec 20, 2024
@msanft msanft added this to the v2.21.0 milestone Dec 20, 2024
@msanft msanft requested a review from burgerdev December 20, 2024 07:49
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 2c7ddee
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/6765217629cd930008d9c9df

@msanft msanft marked this pull request as ready for review December 20, 2024 08:34
@msanft msanft merged commit fcf778e into main Dec 20, 2024
27 of 29 checks passed
@msanft msanft deleted the msanft/ci/fix-stackit branch December 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants