constellation-node-operator: upgrade control plane nodes first #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
force-pushed
the
msanft/operator/cp-nodes-first
branch
3 times, most recently
from
30e0be3 to
3091c75
Compare
msanft
force-pushed
the
msanft/operator/cp-nodes-first
branch
from
3091c75 to
ab7e8c3
Compare
operators/constellation-node-operator/controllers/nodeversion_controller.go
Outdated
Show resolved
Hide resolved
3u13r
requested changes
Feb 24, 2025
|
Manual 1:4 test on GCP succeeded too |
daniel-weisse
approved these changes
Feb 24, 2025
burgerdev
force-pushed
the
burgerdev/k8s-1.31
branch
from
37900d9 to
84fb082
Compare
msanft
force-pushed
the
msanft/operator/cp-nodes-first
branch
2 times, most recently
from
284adc3 to
00fc840
Compare
burgerdev
approved these changes
Feb 26, 2025
operators/constellation-node-operator/controllers/nodeversion_controller.go
Outdated
Show resolved
Hide resolved
msanft
force-pushed
the
msanft/operator/cp-nodes-first
branch
from
00fc840 to
f01527a
Compare
Coverage report
|
burgerdev
pushed a commit
that referenced
this pull request
Feb 26, 2025
burgerdev
pushed a commit
that referenced
this pull request
Feb 26, 2025
burgerdev
added a commit
that referenced
this pull request
Feb 26, 2025
* constellation-node-operator: upgrade control plane nodes first (#3663) * versions: add k8s 1.31, remove k8s 1.28 * e2e: set default k8s version for daily to 1.30 * e2e: remove defaults for required arguments * versions: move 1.31 to the end of the list * kubernetes: set feature gate ControlPlaneKubeletLocalMode Co-Authored-By: Leonard Cohnen <[email protected]> Co-authored-by: Moritz Sanft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since Kubernetes v1.31, the requirement that Kubeletes of version
nare incompatible with outdated (versionn-1) Kube-API servers / control planes is actually enforced / errors if not fulfilled. Thus, we need to make sure during the upgrade that this case doesn't occur in a Constellation cluster.Proposed change(s)
Additional info
Checklist