Skip to content

Commit

Permalink
ci: don't fail fast
Browse files Browse the repository at this point in the history
The matrix strategy defaults to failing fast: If any one of the
test cases fails all other cases get cancelled as well. The problem
with this is that sometimes tests fail not because the code is bad, but
because the test is flaky. In an ideal world, we'd make the tests less
flaky, but until then we shouldn't abort all other tests in the matrix.
The advantage of not failing fast is that when we inevitably have to
manually push the re-run button, we don't have to wait for all test
cases to complete, but only for the one that failed.
  • Loading branch information
Freax13 committed Aug 28, 2024
1 parent 1872e91 commit 7440f70
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/e2e_kubernetes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
strategy:
matrix:
test_name: [servicemesh, openssl, policy, workloadsecret]
fail-fast: false

runs-on: ubuntu-22.04
permissions:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e_openssl_baremetal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
matrix:
test_name: [servicemesh, openssl, policy, workloadsecret]
tee: [SNP, TDX]
fail-fast: false

runs-on:
labels: ${{ matrix.tee }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e_regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- getdents
- genpolicy
- regression
fail-fast: false
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: ./.github/actions/setup_nix
Expand Down

0 comments on commit 7440f70

Please sign in to comment.