e2e: fix log collection download #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
reviewed
Dec 3, 2024
miampf
force-pushed
the
miampf/log-collection-download
branch
from
63b4c8e to
48e6d93
Compare
burgerdev
reviewed
Dec 5, 2024
Do you mean to allow selection between AKS-CLH-SNP and AKS-PEER-SNP? If yes, I can do that if you want :) |
miampf
force-pushed
the
miampf/log-collection-download
branch
3 times, most recently
from
5edcb5d to
905e771
Compare
miampf
force-pushed
the
miampf/log-collection-download
branch
2 times, most recently
from
0628e73 to
da11a37
Compare
burgerdev
reviewed
Dec 12, 2024
miampf
force-pushed
the
miampf/log-collection-download
branch
3 times, most recently
from
175a333 to
c1d25d6
Compare
miampf
force-pushed
the
miampf/log-collection-download
branch
from
c1d25d6 to
33ea1b0
Compare
burgerdev
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, downloading logs from an e2e cluster may fail since the cluster may be undeployed before the download is initiated. This PR fixes that problem by undeploying the cluster after the logs were downloaded.