ci: suffix ci k8s namespaces with "-ci" #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
force-pushed
the
euler/feat/ci/suffix-ci-k8s-namespace-with-ci
branch
3 times, most recently
from
f96384f to
b74cba6
Compare
|
The e2e test aks runtime check seems to be broken on main: https://github.com/edgelesssys/contrast/actions/runs/12179300514/job/33971147711 |
3u13r
force-pushed
the
euler/feat/ci/suffix-ci-k8s-namespace-with-ci
branch
from
b74cba6 to
7866155
Compare
|
In the regression test testregression-2a2a5cbe-ci/mysql-centos-5f9875b787-8blvs reports |
burgerdev
approved these changes
Dec 9, 2024
| @@ -79,7 +79,8 @@ jobs: | |||
| --image-replacements workspace/just.containerlookup \ | |||
| --namespace-file workspace/e2e.namespace \ | |||
| --platform ${{ inputs.platform }} \ | |||
| --skip-undeploy="${{ inputs.skip-undeploy && 'true' || 'false' }}" | |||
| --skip-undeploy="${{ inputs.skip-undeploy && 'true' || 'false' }}" \ | |||
3u13r
force-pushed
the
euler/feat/ci/suffix-ci-k8s-namespace-with-ci
branch
from
7866155 to
20453a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We invoke different e2e tests with the same nix command. This nix command already defines flags that are therefore shared between all current (and future) e2e tests. Let's make it easy to introduce new shared flags while maintaining the possibility that some tests define their own additional flags.
Also introduce a new namespace suffix flag.