Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no ci] contrast runtime tech preview #252

Closed
wants to merge 4 commits into from

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Mar 15, 2024

This PR is not meant to be merged as-is and only outlines my plans for installing a custom runtime class.

How to test

  • git checkout feat/contrast-runtime-tech-preview
  • just node-installer
  • go to the ghcr.io page of the image and mark it as public
  • copy container image with hash as image of installer container in deployments/contrast-node-installer/ds.yml
  • change the namespace of the contrast-node-installer DaemonSet in deployments/contrast-node-installer/ds.yml to default or kube-system
  • k apply -f deployments/contrast-node-installer
  • just

@malt3 malt3 mentioned this pull request Mar 15, 2024
@malt3 malt3 added the no changelog PRs not listed in the release notes label Mar 15, 2024
@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch from 836ff40 to d21783b Compare March 15, 2024 15:21
@malt3 malt3 changed the title contrast runtime tech preview [no ci] contrast runtime tech preview Mar 15, 2024
@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch 5 times, most recently from e3542f6 to a3ea98e Compare March 18, 2024 15:14
@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch 5 times, most recently from 3dc25b8 to 0e50bfd Compare March 25, 2024 14:49
@katexochen
Copy link
Member

Tried to follow the steps, currently getting:

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to get sandbox runtime: no runtime for "contrast-cc" is configured

@malt3
Copy link
Contributor Author

malt3 commented Mar 27, 2024

Tried to follow the steps, currently getting:

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to get sandbox runtime: no runtime for "contrast-cc" is configured

Ah. Yes. This is to be expected. Following some internal discussion, I opted to change the runtime name to include a part of the expected launch digest.
The runtimeclass and all deployment yaml files need to be patched to include the new name (probably dynamically).

For quick testing, you can overwrite handler: contrast-cc in runtimeclass.yaml with the new name. The name is visible in the logs of the installer (/opt/edgeless/RUNTIME_HANDLER_NAME). This is not the final UX and work in progress.

@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch from 0e50bfd to cb781ba Compare April 2, 2024 16:00
@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch from cb781ba to 54460ca Compare April 15, 2024 10:30
@malt3 malt3 force-pushed the feat/contrast-runtime-tech-preview branch from 54460ca to 49f55e2 Compare April 16, 2024 11:51
@malt3
Copy link
Contributor Author

malt3 commented Apr 23, 2024

Everything is either upstreamed or an open PR. 🚀

@malt3 malt3 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants