Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-installer: initialize #253

Merged
merged 1 commit into from
Apr 2, 2024
Merged

node-installer: initialize #253

merged 1 commit into from
Apr 2, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Mar 15, 2024

This is the first step towards a custom runtime class.
The node-installer binary provisions a runtime class on every node of a cluster.

Please also look at #252 for a preview of how the installer is used in practice.

@malt3 malt3 requested a review from katexochen as a code owner March 15, 2024 15:19
@malt3 malt3 added the no changelog PRs not listed in the release notes label Mar 15, 2024
@malt3 malt3 requested a review from 3u13r March 15, 2024 15:40
3u13r
3u13r requested changes Mar 15, 2024
View reviewed changes
node-installer/internal/config/containerd.go Show resolved Hide resolved
node-installer/internal/config/config.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/internal/config/config.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/internal/constants/configuration-clh-snp.toml Show resolved Hide resolved
node-installer/internal/constants/containerd-config.toml Show resolved Hide resolved
packages/by-name/contrast-node-installer/package.nix Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/node-installer branch from ef35e36 to 121181c Compare March 18, 2024 06:50
katexochen
katexochen requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool!

Unit tests are missing, please add them wherever possible.

node-installer/README.md Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/cmd/node-installer.go Outdated Show resolved Hide resolved
node-installer/internal/constants/configuration-clh-snp.toml Show resolved Hide resolved
node-installer/internal/fileop/copy_linux.go Outdated Show resolved Hide resolved
packages/by-name/contrast-node-installer/package.nix Outdated Show resolved Hide resolved
packages/by-name/contrast-node-installer/package.nix Outdated Show resolved Hide resolved
packages/by-name/contrast/package.nix Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/node-installer branch from 121181c to 52222be Compare March 18, 2024 10:49
@malt3
Copy link
Contributor Author

malt3 commented Mar 18, 2024

Working on unit tests now

@malt3 malt3 force-pushed the feat/node-installer branch 4 times, most recently from cf7cd81 to 1cffc17 Compare March 18, 2024 13:25
@malt3 malt3 requested review from katexochen and 3u13r March 18, 2024 15:07
3u13r
3u13r requested changes Mar 18, 2024
View reviewed changes
node-installer/internal/asset/fetcher.go Outdated Show resolved Hide resolved
node-installer/internal/constants/constants.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/copy_linux.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop_test.go Outdated Show resolved Hide resolved
node-installer/node-installer.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/node-installer branch 2 times, most recently from 7cf2731 to 3b9fb59 Compare March 19, 2024 15:15
@malt3 malt3 requested a review from 3u13r March 19, 2024 15:16
@malt3 malt3 force-pushed the feat/node-installer branch 2 times, most recently from 1cce9c0 to 6b3f391 Compare March 25, 2024 14:47
3u13r
3u13r previously requested changes Mar 25, 2024
View reviewed changes
packages/by-name/contrast-node-installer/package.nix Outdated Show resolved Hide resolved
node-installer/node-installer.go Outdated Show resolved Hide resolved
node-installer/node-installer.go Show resolved Hide resolved
node-installer/internal/config/config.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop.go Outdated Show resolved Hide resolved
node-installer/internal/asset/file.go Show resolved Hide resolved
katexochen
katexochen reviewed Mar 27, 2024
View reviewed changes
node-installer/internal/asset/http.go Outdated Show resolved Hide resolved
node-installer/internal/asset/http.go Outdated Show resolved Hide resolved
node-installer/internal/fileop/fileop_test.go Outdated Show resolved Hide resolved
packages/by-name/contrast-node-installer/package.nix Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/node-installer branch 2 times, most recently from d03cda6 to 70b838b Compare April 2, 2024 08:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://edgelesssys.github.io/contrast/pr-preview/pr-253/
on branch gh-pages at 2024-04-02 08:10 UTC

@malt3 malt3 force-pushed the feat/node-installer branch from 70b838b to 02a9865 Compare April 2, 2024 08:13
@malt3 malt3 requested review from katexochen and 3u13r April 2, 2024 08:18
katexochen
katexochen reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some nits left

docs/styles/config/vocabularies/edgeless/accept.txt Outdated Show resolved Hide resolved
docs/styles/config/vocabularies/edgeless/accept.txt Show resolved Hide resolved
node-installer/README.md Outdated Show resolved Hide resolved
node-installer/internal/asset/fetcher_test.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/node-installer branch from 02a9865 to 0da11f9 Compare April 2, 2024 13:27
@malt3 malt3 dismissed 3u13r’s stale review April 2, 2024 15:49

Katexochen reviewed and approved.

@malt3 malt3 merged commit 3b1ea3d into main Apr 2, 2024
8 checks passed
@malt3 malt3 deleted the feat/node-installer branch April 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @3u13r @katexochen