Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add smoke test for peer pods #1005

Merged
merged 4 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .github/workflows/e2e_peerpods.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: e2e peer-pods

on:
workflow_dispatch:
inputs:
image-id:
description: "ID of the guest VM image to test (default: build a fresh image)"
required: false
pull_request:
paths:
- .github/workflows/e2e_peerpods.yml
- packages/test-peerpods.sh
- packages/by-name/cloud-api-adaptor/**
- packages/by-name/kata/**
- packages/by-name/image-podvm/**
- packages/nixos

jobs:
test:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./.github/actions/setup_nix
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
cachixToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
- name: Login to Azure
uses: azure/login@a65d910e8af852a8061c627c456678983e180302 # v2.2.0
with:
creds: ${{ secrets.CONTRAST_CI_INFRA_AZURE }}
- name: Test peer-pods
env:
azure_subscription_id: ${{ vars.AZURE_SUBSCRIPTION_ID }}
azure_image_id: ${{ inputs.image-id }}
azure_resource_group: contrast-ci
azure_location: germanywestcentral
CONTRAST_CACHE_DIR: "./workspace.cache"
run: |
ssh-keygen -t rsa -f ./infra/azure-peerpods/id_rsa -N ""
cat >infra/azure-peerpods/iam.auto.tfvars <<EOF
tenant_id = "${{ vars.AZURE_TENANT_ID }}"
client_id = "${{ vars.PEER_POD_CLIENT_ID_AZURE }}"
client_secret = "${{ secrets.PEER_POD_CLIENT_SECRET_AZURE }}"
resource_group = "contrast-ci"
EOF
nix run .#scripts.test-peerpods
- name: Terminate cluster
if: always()
run: |
nix run -L .#terraform -- -chdir=infra/azure-peerpods destroy --auto-approve
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ id_rsa*
kube.conf
out.env
infra/**/kustomization.yaml
infra/**/workload-identity.yaml
uplosi.conf*
62 changes: 62 additions & 0 deletions infra/azure-peerpods-iam/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 75 additions & 0 deletions infra/azure-peerpods-iam/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "4.5.0"
}
azuread = {
source = "hashicorp/azuread"
version = "3.0.2"
}
local = {
source = "hashicorp/local"
version = "2.5.2"
}
}
}

provider "azurerm" {
subscription_id = var.subscription_id
features {
resource_group {
prevent_deletion_if_contains_resources = false
}
}
}

data "azurerm_subscription" "current" {}

data "azuread_client_config" "current" {}

provider "azuread" {
tenant_id = data.azurerm_subscription.current.tenant_id
}

locals {
name = var.resource_group
}

resource "azurerm_resource_group" "rg" {
name = var.resource_group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still add a suffix somewhere to make this azure/peerpod specific. Otherwise rg might collide with aks/nested setup.

Also, upload-image step still expects a the _caa_cluster suffix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I added the _caa_cluster suffix back. Original reason for using the literal group was so that I can reuse contrast-ci, but now that the RG is owned by create-pre it does not matter anymore.

location = var.location
}

resource "azuread_application" "app" {
display_name = "${local.name}-app"
owners = [data.azuread_client_config.current.object_id]
}

resource "azuread_service_principal" "sp" {
client_id = azuread_application.app.client_id
app_role_assignment_required = false
owners = [data.azuread_client_config.current.object_id]
}

resource "azurerm_role_assignment" "ra_vm_contributor" {
scope = azurerm_resource_group.rg.id
role_definition_name = "Virtual Machine Contributor"
principal_id = azuread_service_principal.sp.object_id
}

resource "azurerm_role_assignment" "ra_reader" {
scope = azurerm_resource_group.rg.id
role_definition_name = "Reader"
principal_id = azuread_service_principal.sp.object_id
}

resource "azurerm_role_assignment" "ra_network_contributor" {
scope = azurerm_resource_group.rg.id
role_definition_name = "Network Contributor"
principal_id = azuread_service_principal.sp.object_id
}

resource "azuread_application_password" "pw" {
application_id = azuread_application.app.id
}
8 changes: 8 additions & 0 deletions infra/azure-peerpods-iam/outs.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
output "client_secret_env" {
value = <<EOF
client_id = "${azuread_application.app.client_id}"
tenant_id = "${data.azurerm_subscription.current.tenant_id}"
client_secret = "${azuread_application_password.pw.value}"
EOF
sensitive = true
}
11 changes: 11 additions & 0 deletions infra/azure-peerpods-iam/vars.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
variable "resource_group" {
type = string
}

variable "location" {
type = string
}

variable "subscription_id" {
type = string
}
30 changes: 0 additions & 30 deletions infra/azure-peerpods/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

89 changes: 7 additions & 82 deletions infra/azure-peerpods/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ terraform {
source = "hashicorp/azurerm"
version = "4.8.0"
}
azuread = {
source = "hashicorp/azuread"
version = "3.0.2"
}
local = {
source = "hashicorp/local"
version = "2.5.2"
Expand All @@ -26,63 +22,16 @@ provider "azurerm" {

data "azurerm_subscription" "current" {}

data "azuread_client_config" "current" {}

provider "azuread" {
tenant_id = data.azurerm_subscription.current.tenant_id
}

locals {
name = "${var.name_prefix}_caa_cluster"
name = "${var.name_prefix}contrast_pp"
}

data "azurerm_resource_group" "rg" {
name = local.name
}

resource "azuread_application" "app" {
display_name = local.name
owners = [data.azuread_client_config.current.object_id]
}

resource "azuread_service_principal" "sp" {
client_id = azuread_application.app.client_id
app_role_assignment_required = false
owners = [data.azuread_client_config.current.object_id]
}

resource "azurerm_role_assignment" "ra_vm_contributor" {
scope = data.azurerm_resource_group.rg.id
role_definition_name = "Virtual Machine Contributor"
principal_id = azuread_service_principal.sp.object_id
}

resource "azurerm_role_assignment" "ra_reader" {
scope = data.azurerm_resource_group.rg.id
role_definition_name = "Reader"
principal_id = azuread_service_principal.sp.object_id
}

resource "azurerm_role_assignment" "ra_network_contributor" {
scope = data.azurerm_resource_group.rg.id
role_definition_name = "Network Contributor"
principal_id = azuread_service_principal.sp.object_id
}

resource "azuread_application_federated_identity_credential" "federated_credentials" {
display_name = local.name
application_id = azuread_application.app.id
issuer = azurerm_kubernetes_cluster.cluster.oidc_issuer_url
subject = "system:serviceaccount:confidential-containers-system:cloud-api-adaptor"
audiences = ["api://AzureADTokenExchange"]
}

resource "azuread_application_password" "cred" {
application_id = azuread_application.app.id
name = var.resource_group
}

resource "azurerm_virtual_network" "main" {
name = local.name
name = "${local.name}_net"
address_space = ["10.0.0.0/8"]
location = data.azurerm_resource_group.rg.location
resource_group_name = data.azurerm_resource_group.rg.name
Expand All @@ -96,7 +45,7 @@ resource "azurerm_virtual_network" "main" {
resource "azurerm_kubernetes_cluster" "cluster" {
name = "${local.name}_aks"
resource_group_name = data.azurerm_resource_group.rg.name
node_resource_group = "${local.name}_node_rg"
node_resource_group = "${var.resource_group}_aks_node_rg"
location = data.azurerm_resource_group.rg.location
dns_prefix = "aks"
oidc_issuer_enabled = true
Expand Down Expand Up @@ -128,31 +77,6 @@ resource "local_file" "kubeconfig" {
content = azurerm_kubernetes_cluster.cluster.kube_config_raw
}

resource "local_file" "workload_identity" {
filename = "./workload-identity.yaml"
file_permission = "0777"
content = <<EOF
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: cloud-api-adaptor-daemonset
namespace: confidential-containers-system
spec:
template:
metadata:
labels:
azure.workload.identity/use: "true"
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: cloud-api-adaptor
namespace: confidential-containers-system
annotations:
azure.workload.identity/client-id: ${azuread_application.app.client_id}
EOF
}

resource "local_file" "kustomization" {
filename = "./kustomization.yaml"
file_permission = "0777"
Expand All @@ -178,6 +102,9 @@ configMapGenerator:
- AZURE_RESOURCE_GROUP=${data.azurerm_resource_group.rg.name}
- AZURE_SUBNET_ID=${one(azurerm_virtual_network.main.subnet.*.id)}
- AZURE_IMAGE_ID=${var.image_id}
- AZURE_CLIENT_ID=${var.client_id}
- AZURE_TENANT_ID=${var.tenant_id}
- AZURE_CLIENT_SECRET=${var.client_secret}
- DISABLECVM=false
secretGenerator:
- name: peer-pods-secret
Expand All @@ -186,7 +113,5 @@ secretGenerator:
namespace: confidential-containers-system
files:
- id_rsa.pub
patchesStrategicMerge:
- workload-identity.yaml
EOF
}
Loading