Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: add log messages for handshake failures #1010

Merged
merged 1 commit into from
Nov 18, 2024
Merged

coordinator: add log messages for handshake failures #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion coordinator/internal/authority/credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ func (a *Authority) Credentials(reg *prometheus.Registry, issuer atls.Issuer) (*
//
// If successful, the state will be passed to gRPC as [AuthInfo].
func (c *Credentials) ServerHandshake(rawConn net.Conn) (net.Conn, credentials.AuthInfo, error) {
log := c.logger.With("peer", rawConn.RemoteAddr())
state, err := c.getState()
if err != nil {
log.Error("Could not get manifest state to validate peer", "error", err)
return nil, nil, fmt.Errorf("getting state: %w", err)
}

Expand All @@ -79,6 +81,7 @@ func (c *Credentials) ServerHandshake(rawConn net.Conn) (net.Conn, credentials.A

opts, err := state.Manifest.SNPValidateOpts(c.kdsGetter)
if err != nil {
log.Error("Could not generate SNP validation options", "error", err)
return nil, nil, fmt.Errorf("generating SNP validation options: %w", err)
}

Expand All @@ -91,6 +94,7 @@ func (c *Credentials) ServerHandshake(rawConn net.Conn) (net.Conn, credentials.A

tdxOpts, err := state.Manifest.TDXValidateOpts()
if err != nil {
log.Error("Could not generate TDX validation options", "error", err)
return nil, nil, fmt.Errorf("generating TDX validation options: %w", err)
}
for _, opt := range tdxOpts {
Expand All @@ -100,18 +104,20 @@ func (c *Credentials) ServerHandshake(rawConn net.Conn) (net.Conn, credentials.A

serverCfg, err := atls.CreateAttestationServerTLSConfig(c.issuer, validators, c.attestationFailuresCounter)
if err != nil {
log.Error("Could not create TLS config", "error", err)
return nil, nil, err
}

conn, info, err := credentials.NewTLS(serverCfg).ServerHandshake(rawConn)
if err != nil {
log.Error("ServerHandshake failed", "error", err)
return nil, nil, err
}
tlsInfo, ok := info.(credentials.TLSInfo)
if ok {
authInfo.TLSInfo = tlsInfo
} else {
c.logger.Error("credentials.NewTLS returned unexpected AuthInfo", "obj", info)
log.Error("credentials.NewTLS returned unexpected AuthInfo", "obj", info)
}

return conn, authInfo, nil
Expand Down
Loading