Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix policy test dependence on default policy test #1031

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Nov 25, 2024

This fixes a bug introduced into the policy test in PR #1007, because of dependence of the policy test on the default policy test executed prior. Restarting the applied resources cleans up the containers being in FailedToCreatePodSandbox state, which takes place when started with the default policy annotation and thus allows to continue the test workflow with the generated manifest.

@jmxnzo jmxnzo requested a review from burgerdev as a code owner November 25, 2024 17:17
@jmxnzo jmxnzo added bug fix Fixing a user facing bug no changelog PRs not listed in the release notes labels Nov 25, 2024
@jmxnzo jmxnzo mentioned this pull request Nov 25, 2024
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@burgerdev burgerdev removed the bug fix Fixing a user facing bug label Nov 26, 2024
@burgerdev
Copy link
Contributor

(removed the bug fix label, as it's for user facing bugs and this bug is not user facing)

@jmxnzo jmxnzo merged commit ecf5007 into main Nov 26, 2024
9 of 10 checks passed
@jmxnzo jmxnzo deleted the e2e-no-policy-jla branch November 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants