Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: pass environment variables to genpolicy #1033

Merged
merged 1 commit into from
Nov 27, 2024
Merged

cli: pass environment variables to genpolicy #1033

merged 1 commit into from
Nov 27, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Nov 26, 2024 •
edited
Loading

This allows

  • running contrast generate with HTTP_PROXY and friends
  • using registry credentials from various filesystem paths supported by the docker_credential crate (this is not enough for full private registry support!)

@burgerdev burgerdev requested a review from msanft November 26, 2024 10:25
@burgerdev burgerdev added the bug fix Fixing a user facing bug label Nov 26, 2024
@burgerdev burgerdev changed the title cli: pass selected env vars to genpolicy cli: allow pulling images from private registries Nov 26, 2024
@burgerdev burgerdev force-pushed the burgerdev/genpolicy-env branch from 814ee1b to 331f314 Compare November 26, 2024 16:56
@burgerdev burgerdev requested a review from 3u13r November 26, 2024 17:30
3u13r
3u13r reviewed Nov 27, 2024
View reviewed changes
cli/genpolicy/genpolicy.go Outdated Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/genpolicy-env branch from 331f314 to e3b0ba6 Compare November 27, 2024 11:08
@burgerdev burgerdev requested review from 3u13r and removed request for msanft November 27, 2024 11:09
3u13r
3u13r approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev changed the title cli: allow pulling images from private registries cli: pass environment variables to genpolicy Nov 27, 2024
@burgerdev burgerdev merged commit c375309 into main Nov 27, 2024
10 checks passed
@burgerdev burgerdev deleted the burgerdev/genpolicy-env branch November 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3u13r 3u13r 3u13r approved these changes

@katexochen katexochen Awaiting requested review from katexochen

Assignees
No one assigned
Labels
bug fix Fixing a user facing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @3u13r