Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-img: disable patchelf on executable-marked OS image #1034

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Nov 26, 2024

Prior, we tried to run patchelf (automatically, due to the Nix stdenv) on the executable-marked OS image. This is not necessary and costs a considerable investment of time. The PR excludes the automatic patchelf hook from the build.

@jmxnzo jmxnzo added the changelog PRs that should be part of the release notes label Nov 26, 2024
@jmxnzo jmxnzo requested a review from katexochen as a code owner November 26, 2024 12:33
@jmxnzo jmxnzo force-pushed the patchelf-removal-jla branch from b4a242f to 5655eec Compare November 26, 2024 14:20
@jmxnzo jmxnzo requested a review from msanft November 26, 2024 14:21
@jmxnzo jmxnzo changed the title nixos-img: disable patchelf on cloud-hypervisor image nixos-img: disable patchelf on executable-marked OS image Nov 28, 2024
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the comment.

The check that fails is only formatting. I think you should be able to run just fmt, which should fix this.

@katexochen katexochen removed their request for review November 29, 2024 06:17
@jmxnzo jmxnzo force-pushed the patchelf-removal-jla branch from 5655eec to aeaf2e6 Compare November 29, 2024 08:10
@jmxnzo jmxnzo force-pushed the patchelf-removal-jla branch from aeaf2e6 to 3c67acb Compare November 29, 2024 08:17
@jmxnzo jmxnzo requested a review from msanft November 29, 2024 08:55
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@jmxnzo jmxnzo merged commit 7dd0881 into main Nov 29, 2024
12 checks passed
@jmxnzo jmxnzo deleted the patchelf-removal-jla branch November 29, 2024 10:02
@katexochen katexochen added no changelog PRs not listed in the release notes and removed changelog PRs that should be part of the release notes labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants