kds-cache: add fallback cache for CRLs on request failure #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmxnzo
changed the title
jmxnzo
force-pushed
the
kds-caching-jla
branch
from
c391d3d to
c26a603
Compare
jmxnzo
changed the title
jmxnzo
force-pushed
the
kds-caching-jla
branch
from
c26a603 to
5a0bba9
Compare
katexochen
reviewed
Dec 9, 2024
katexochen
reviewed
Dec 9, 2024
katexochen
reviewed
Dec 9, 2024
katexochen
reviewed
Dec 9, 2024
katexochen
reviewed
Dec 9, 2024
katexochen
reviewed
Dec 9, 2024
The expiration date is checked right here https://github.com/google/go-sev-guest/blob/main/verify/verify.go#L303-L305 . As well the usage of CachedHTTPSGetter by the CRL request was re-examined: it is ensured by handing in the shared CachedHTTPSGetter as verify.Options (see https://github.com/google/go-sev-guest/blob/main/verify/verify.go#L308). In summary we keep sharing one cache across all of the certificates and revocation list, using the same kds-Getter in the verify.Options (https://github.com/edgelesssys/contrast/blob/main/coordinator/internal/authority/credentials.go#L82). |
jmxnzo
force-pushed
the
kds-caching-jla
branch
from
5a0bba9 to
bd242ac
Compare
katexochen
approved these changes
Dec 12, 2024
jmxnzo
force-pushed
the
kds-caching-jla
branch
from
bd242ac to
cd2a7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the cached_client.go to allow caching Certificate Revocation Lists (CRLs). Still the CRLs are always queried from the AMD's certification server (KDS) first.
Only in case of an request failure, the cache is used as fallback to allow continuing. When the cache of the CRL is expired, the HTTPs request failure is returned as an error.
In addition the test cases where adapted to cover the different branches of VCEK and CRL caching.