nixos/kata: pull in multi-user.target
#1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, due to setting `systemd.unit=kata-containers.target` on the kernel command line, we didn't pull in units that are `wantedBy=multi-user.target`. This breaks many assumptions of upstream software, including those of `nvidia-persistenced.service`, which was the first component that exhibited a hard breakage upon this unfulfilled assumption. This fixes these assumptions by pulling in `multi-user.target` through `kata-containers.target`.
|
Skipping this for now: https://dev.azure.com/Edgeless/Edgeless/_backlogs/backlog/Edgeless Team/Features?workitem=4973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to setting
systemd.unit=kata-containers.targeton the kernel command line, we didn't pull in units that arewantedBy=multi-user.target. This breaks many assumptions of upstream software, including those ofnvidia-persistenced.service, which was the first component that exhibited a hard breakage upon this unfulfilled assumption. This fixes these assumptions by pulling inmulti-user.targetthroughkata-containers.target.